Skip to contentSkip to conversation

io_uring/futex: always remove futex entry for cancel all

PATCH New Jens Axboe 1 participant 1 message Mar 15, 2024 io_uring

lore
Share & tools
lore

Jens Axboe

author maintainer
#0 lore raw

PATCH 1/1 io_uring/futex: always remove futex entry for cancel all

We know the request is either being removed, or already in the process of being removed through task_work, so we can delete it from our futex list upfront. This is important for remove all conditions, as we otherwise will find it multiple times and prevent cancelation progress.

Fixes 194bb58c6090 ("io_uring: add support for futex wake and wait")
Fixes 8f350194d5cf ("io_uring: add support for vectored futex waits")

---

io_uring/futex.c +1 -0
index 3c3575303c3d..792a03df58de 100644
@@ -159,6 +159,7 @@ bool io_futex_remove_all(struct io_ring_ctx *ctx, struct task_struct *task,
 	hlist_for_each_entry_safe(req, tmp, &ctx->futex_list, hash_node) {
 		if (!io_match_task_safe(req, task, cancel_all))
 			continue;
+		hlist_del_init(&req->hash_node);
 		__io_futex_cancel(ctx, req);
 		found = true;
 	}
Signature · 1 line
Jens Axboe