Skip to contentSkip to conversation

correct wording in drivers/usb/net/KConfig

PATCH In review Koen Kooi 2 participants 3 messages Oct 26, 2005 – Nov 1, 2005

lore
Share & tools
lore
#1 lore raw
In reply to Koen Kooi

usb/net/Kconfig 2005-10-25 14:10:30.644935296 +0200 line 297

Quoted 7 lines · Koen Kooi

+++ drivers/usb/net/Kconfig 2005-10-25 14:10:30.644935296 +0200

usb/net/Kconfig 2005-10-25 14:10:30.644935296 +0200 renamed from Kconfig 2005-10-25 14:09:29.442239520 +0200 +1 -1
@@ -294,7 +294,7 @@
          This also supports some related device firmware, as used in some
          PDAs from Olympus and some cell phones from Motorola.
 
-         If you install an alternate ROM image, such as the Linux 2.6 based
+         If you install an alternate image, such as the Linux 2.6 based

Your email client ate the tabs in the patch, and you forgot a "Signed-off-by:" line for the patch. Care to try it again?

thanks,

greg k-h

Koen Kooi

author
#0 lore raw

PATCH 1/1 correct wording in drivers/usb/net/KConfig

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

drivers/usb/net/KConfig mention the word ROM ('Read Only Memory') a few times in combination with the Sharp Zaurus family. The original software from sharp (and clones) use cramfs as a root partition which indeed is Read only. OpenZaurus however (and other distributions like Familiar) use jffs2 as a filesystem for the rootfs on flash, so ROM is not the correct term to use. Attached is a patch which removes the word 'ROM' in the sentence mentioning OpenZaurus.

regards,

Koen Kooi
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Darwin)

iD8DBQFDXiNiMkyGM64RGpERAqwOAJ94Pa3w0ww2yi0a/9bFR7oORAjm9wCgjavX HThMWubjyE5UGRaiC/lIP78=
=1vIW
-----END PGP SIGNATURE-----

usb/net/Kconfig 2005-10-25 14:10:30.644935296 +0200 renamed from Kconfig 2005-10-25 14:09:29.442239520 +0200 +1 -1
@@ -294,7 +294,7 @@
          This also supports some related device firmware, as used in some
          PDAs from Olympus and some cell phones from Motorola.
 
-         If you install an alternate ROM image, such as the Linux 2.6 based
+         If you install an alternate image, such as the Linux 2.6 based
          versions of OpenZaurus, you should no longer need to support this
          protocol.  Only the "eth-fd" or "net_fd" drivers in these devices
          really need this non-conformant variant of CDC Ethernet (or in
author
#2 lore raw
In reply to Greg KH

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 7 lines · Greg KH
Quoted 5 lines · Koen Kooi

+++ drivers/usb/net/Kconfig 2005-10-25 14:10:30.644935296 +0200

(quoted diff) +0 -0
@@ -294,7 +294,7 @@
         This also supports some related device firmware, as used in some
         PDAs from Olympus and some cell phones from Motorola.
 
Quoted 6 lines

Review line 297

Quoted 2 lines
(quoted diff) +1 -1
-         If you install an alternate ROM image, such as the Linux 2.6 based
+         If you install an alternate image, such as the Linux 2.6 based

Your email client ate the tabs in the patch, and you forgot a "Signed-off-by:" line for the patch. Care to try it again?

Sure, attached should be a patch with correct tabs and a signed-off-by line.

regards,

Koen

Quoted 5 lines

thanks,

greg k-h

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Darwin)

iD8DBQFDX8AdMkyGM64RGpERAohSAKCO1G22HGwFbl4UPOkHm7BzmpBpggCeIPO9 RMhvH5wW/n7BFjPGc00FSlc=
=DLez
-----END PGP SIGNATURE-----

# Signed-off-by: Koen Kooi <[email protected]>
============================================================================================================================================================================================

usb/net/Kconfig renamed from Kconfig +1 -1
@@ -294,7 +294,7 @@
 	  This also supports some related device firmware, as used in some
 	  PDAs from Olympus and some cell phones from Motorola.
 
-	  If you install an alternate ROM image, such as the Linux 2.6 based
+	  If you install an alternate image, such as the Linux 2.6 based
 	  versions of OpenZaurus, you should no longer need to support this
 	  protocol.  Only the "eth-fd" or "net_fd" drivers in these devices
 	  really need this non-conformant variant of CDC Ethernet (or in