Skip to contentSkip to conversation

Use LDFLAGS instead of ALL_CFLAGS when linking.

PATCH In review Andreas Ericsson 2 participants 2 messages Jun 15, 2016 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Use LDFLAGS instead of ALL_CFLAGS when linking.

The patch says it all really. It lets users specify their own linking options and unclutters the build-output somewhat.

index 5b0306d..f547d45 100644

Makefile +1 -1
@@ -360,7 +360,7 @@ git-cherry-pick: git-revert
        $(CC) -o $*.o -c $(ALL_CFLAGS) $<
 
 git-%$X: %.o $(LIB_FILE)
-       $(CC) $(ALL_CFLAGS) -o $@ $(filter %.o,$^) $(LIBS)
+       $(CC) -o $@ $(filter %.o,$^) $(LIBS) $(LDFLAGS)
 
 git-mailinfo$X : SIMPLE_LIB += $(LIB_4_ICONV)
 $(SIMPLE_PROGRAMS) : $(LIB_FILE)
Signature · 3 lines
Andreas Ericsson                   [email protected]
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231
#1 lore raw

Makefile git-cherry-pick: git-revert · line 364

Quoted 12 lines · Andreas Ericsson

The patch says it all really. It lets users specify their own linking options and unclutters the build-output somewhat.

index 5b0306d..f547d45 100644

Makefile +1 -1
@@ -360,7 +360,7 @@ git-cherry-pick: git-revert
        $(CC) -o $*.o -c $(ALL_CFLAGS) $<
 
 git-%$X: %.o $(LIB_FILE)
-       $(CC) $(ALL_CFLAGS) -o $@ $(filter %.o,$^) $(LIBS)
+       $(CC) -o $@ $(filter %.o,$^) $(LIBS) $(LDFLAGS)
 

Typically $(LDFLAGS) comes before $(LIBS). This is not insignificant, since some people put library seach options into LDFLAGS.

-hpa