Skip to contentSkip to conversation

v4l: prevent saa7134 alsa undefined warnings

PATCH Mike Krufky 2 participants 3 messages Nov 10, 2005 – Nov 11, 2005 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Prevent the following build warnings:

*** Warning: "snd_card_free"
*** Warning: "snd_card_register"
*** Warning: "snd_device_new"
*** Warning: "snd_card_new"
*** Warning: "snd_ctl_add"
*** Warning: "snd_ctl_new1"
*** Warning: "snd_pcm_set_ops"
*** Warning: "snd_pcm_new"
*** Warning: "snd_pcm_lib_ioctl"
*** Warning: "snd_pcm_hw_constraint_integer" *** Warning: "snd_pcm_stop"
*** Warning: "snd_pcm_period_elapsed" [drivers/media/video/saa7134/saa7134-alsa.ko] undefined!

 drivers/media/video/saa7134/Kconfig |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/media/video/saa7134/Kconfig +1 -1
@@ -1,6 +1,6 @@
 config VIDEO_SAA7134
 	tristate "Philips SAA7134 support"
-	depends on VIDEO_DEV && PCI && I2C && SOUND
+	depends on VIDEO_DEV && PCI && I2C && SOUND && SND && SND_PCM_OSS
 	select VIDEO_BUF
 	select VIDEO_IR
 	select VIDEO_TUNER
#1 lore raw

At Thu, 10 Nov 2005 17:37:58 -0500,

Quoted 26 lines · Mike Krufky

Prevent the following build warnings:

*** Warning: "snd_card_free"
*** Warning: "snd_card_register"
*** Warning: "snd_device_new"
*** Warning: "snd_card_new"
*** Warning: "snd_ctl_add"
*** Warning: "snd_ctl_new1"
*** Warning: "snd_pcm_set_ops"
*** Warning: "snd_pcm_new"
*** Warning: "snd_pcm_lib_ioctl"
*** Warning: "snd_pcm_hw_constraint_integer" *** Warning: "snd_pcm_stop"
*** Warning: "snd_pcm_period_elapsed" [drivers/media/video/saa7134/saa7134-alsa.ko] undefined!

 drivers/media/video/saa7134/Kconfig |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

drivers/media/video/saa7134/Kconfig line 3

Quoted 4 lines
drivers/media/video/saa7134/Kconfig +1 -1
@@ -1,6 +1,6 @@
 config VIDEO_SAA7134
 	tristate "Philips SAA7134 support"
-	depends on VIDEO_DEV && PCI && I2C && SOUND
+	depends on VIDEO_DEV && PCI && I2C && SOUND && SND && SND_PCM_OSS

No, this driver should select SND_PCM_OSS, instead.

Takashi

#2 lore raw
Quoted 27 lines · Takashi Iwai

At Thu, 10 Nov 2005 17:37:58 -0500,

Quoted 17 lines · Mike Krufky

Prevent the following build warnings:

*** Warning: "snd_card_free" *** Warning: "snd_card_register" *** Warning: "snd_device_new" *** Warning: "snd_card_new" *** Warning: "snd_ctl_add"
*** Warning: "snd_ctl_new1" *** Warning: "snd_pcm_set_ops" *** Warning: "snd_pcm_new"
*** Warning: "snd_pcm_lib_ioctl" *** Warning: "snd_pcm_hw_constraint_integer" *** Warning: "snd_pcm_stop" *** Warning: "snd_pcm_period_elapsed" [drivers/media/video/saa7134/saa7134-alsa.ko] undefined!

drivers/media/video/saa7134/Kconfig | 2 +-

1 files changed, 1 insertion(+), 1 deletion(-)
drivers/media/video/saa7134/Kconfig +0 -0
@@ -1,6 +1,6 @@

config VIDEO_SAA7134
tristate "Philips SAA7134 support"

drivers/media/video/saa7134/Kconfig line 3

Quoted 2 lines
drivers/media/video/saa7134/Kconfig +1 -1
-	depends on VIDEO_DEV && PCI && I2C && SOUND
+	depends on VIDEO_DEV && PCI && I2C && SOUND && SND && SND_PCM_OSS

No, this driver should select SND_PCM_OSS, instead.

Quoted 1 line

Takashi

Yes, I realized that after Andrew applied the patch. We will send a correction in our next patchset.

-Michael Krufky