Skip to contentSkip to conversation

drivers/net/wireless/airo.c unsigned comparason

PATCH RESEND In review Gabriel A. Devenyi 2 participants 2 messages Nov 11, 2005 – Dec 1, 2005 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 drivers/net/wireless/airo.c unsigned comparason

fid is declared as a u32 (unsigned int), and then a few lines later, it is checked for a value < 0, which is clearly useless. In the two locations this function is used, in one it is *explicitly* given a negative number, which would be ignored with the current definition.

Thanks to LinuxICC (http://linuxicc.sf.net).

This patch applies to linus' git tree as of 03.11.2005

drivers/net/wireless/airo.c +1 -1
index 750c016..849ac88 100644
@@ -2040,7 +2040,7 @@ static int mpi_send_packet (struct net_d
 	return 1;
 }
 
-static void get_tx_error(struct airo_info *ai, u32 fid)
+static void get_tx_error(struct airo_info *ai, s32 fid)
 {
 	u16 status;
 
Signature · 2 lines
Gabriel A. Devenyi
[email protected]
#1 lore raw
Quoted 9 lines · Gabriel A. Devenyi

fid is declared as a u32 (unsigned int), and then a few lines later, it is checked for a value < 0, which is clearly useless. In the two locations this function is used, in one it is *explicitly* given a negative number, which would be ignored with the current definition.

Thanks to LinuxICC (http://linuxicc.sf.net).

This patch applies to linus' git tree as of 03.11.2005

[jgarzik@pretzel netdev-2.6]$ git-applymbox /g/tmp/mbox ~/info/signoff.txt 1 patch(es) to process.

Applying 'drivers/net/wireless/airo.c unsigned comparason'

fatal: corrupt patch at line 8