Skip to contentSkip to conversation

IPv6: small fix for ipv6_dev_get_saddr(...)

PATCH Applied Yan Zheng 3 participants 3 messages Nov 14, 2005 – Nov 15, 2005

Subsystems (3)
Networking Network drivers IPv4/IPv6
lore
Share & tools
lore

Yan Zheng

author
#0 lore raw

PATCH 1/1 IPv6: small fix for ipv6_dev_get_saddr(...)

The "score.rule++" doesn't make any sense for me. According to codes above, I think it should be "hiscore.rule++;" .

Signed-off-by Yan Zheng<[email protected]>
net/ipv6/addrconf.c +0 -0
Index: net/ipv6/addrconf.c
============================================================
@@ -1045,9 +1045,10 @@ int ipv6_dev_get_saddr(struct net_device

			}
#endif
			/* Rule 8: Use longest matching prefix */
-			if (hiscore.rule < 8)
+			if (hiscore.rule < 8) {
				hiscore.matchlen = ipv6_addr_diff(&ifa_result->addr, daddr);
-			score.rule++;
+				hiscore.rule++;
+			}
			score.matchlen = ipv6_addr_diff(&ifa->addr, daddr);
			if (score.matchlen > hiscore.matchlen) {
				score.rule = 8;
Acked-by on v1 1/1
#1 lore raw

In article <[email protected]> (at Mon, 14 Nov 2005 18:42:30 +0800), Yan Zheng <[email protected]> says:

Quoted 2 lines

The "score.rule++" doesn't make any sense for me. According to codes above, I think it should be "hiscore.rule++;" .

Oops, you're right.

Quoted 1 line
Signed-off-by Yan Zheng<[email protected]>
Acked-by YOSHIFUJI Hideaki <[email protected]>
Quoted 11 lines
(quoted diff) +3 -2
 			/* Rule 8: Use longest matching prefix */
-			if (hiscore.rule < 8)
+			if (hiscore.rule < 8) {
 				hiscore.matchlen = ipv6_addr_diff(&ifa_result->addr, daddr);
-			score.rule++;
+				hiscore.rule++;
+			}
 			score.matchlen = ipv6_addr_diff(&ifa->addr, daddr);
 			if (score.matchlen > hiscore.matchlen) {
 				score.rule = 8;
Signature · 2 lines
YOSHIFUJI Hideaki @ USAGI Project  <[email protected]>
GPG-FP  : 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA
maintainer Applied
#2 lore raw

From: YOSHIFUJI Hideaki <[email protected]>
Date: Tue, 15 Nov 2005 10:22:37 +0900 (JST)

Quoted 9 lines

In article <[email protected]> (at Mon, 14 Nov 2005 18:42:30 +0800), Yan Zheng <[email protected]> says:

Quoted 2 lines

The "score.rule++" doesn't make any sense for me. According to codes above, I think it should be "hiscore.rule++;" .

Oops, you're right.

Quoted 1 line
Signed-off-by Yan Zheng<[email protected]>
Acked-by YOSHIFUJI Hideaki <[email protected]>

Applied.