Skip to contentSkip to conversation

Fix copy-paste bug after _Convert platform drivers to use_ (again)

PATCH Applied Andrey Volkov 2 participants 3 messages Nov 15, 2005 – Nov 17, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix copy-paste bug after _Convert platform drivers to use_ (again)

Hello Russell,

I fear it is not a last patch of such kind :(.
Please recheck places where you are changed
pdev<->dev.

Signature · 2 lines
Regards
Andrey Volkov

Fix copy-paste bug in ohci-ppc-soc.c(ohci_hcd_ppc_soc_drv_remove)

---

drivers/usb/host/ohci-ppc-soc.c +1 -1
index 1875576..2ec6a78 100644
@@ -185,7 +185,7 @@ static int ohci_hcd_ppc_soc_drv_probe(st
 
 static int ohci_hcd_ppc_soc_drv_remove(struct platform_device *pdev)
 {
-	struct usb_hcd *hcd = platform_get_drvdata(dev);
+	struct usb_hcd *hcd = platform_get_drvdata(pdev);
 
 	usb_hcd_ppc_soc_remove(hcd, pdev);
 	return 0;
#1 lore raw
Quoted 5 lines · Andrey Volkov

Hello Russell,

I fear it is not a last patch of such kind :(.
Please recheck places where you are changed
pdev<->dev.

Either that will have to wait a number of days or someone else will have to do that. I'm sorry but I'm rather unwell and in no fit state to do anything major with kernels atm.

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
Applied
#2 lore raw
In reply to Andrey Volkov
Quoted 3 lines · Andrey Volkov

I fear it is not a last patch of such kind :(.
Please recheck places where you are changed
pdev<->dev.

Applied. However, what you ask is to review the entire kernel looking for a one-character error needle in a massive haystack. That's a job better suited to compilers than eyes.

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core