PVR wrong for mpc8343 chips.
Hi.
The PVRs are wrongly enumerated for the 8343/8343e chips.
-dbu
arch/ppc/syslib/mpc83xx_sys.c +30 -6
@@ -69,29 +69,53 @@ struct ppc_sys_spec ppc_sys_specs[] = { }, }, { - .ppc_sys_name = "8343E", + .ppc_sys_name = "8347E", .mask = 0xFFFF0000, .value = 0x80540000, - .num_devices = 7, + .num_devices = 8, .device_list = (enum ppc_sys_devices []) { MPC83xx_TSEC1, MPC83xx_TSEC2, MPC83xx_IIC1, MPC83xx_IIC2, MPC83xx_DUART, MPC83xx_SEC2, - MPC83xx_USB2_DR, + MPC83xx_USB2_DR, MPC83xx_USB2_MPH }, }, { - .ppc_sys_name = "8343", + .ppc_sys_name = "8347", .mask = 0xFFFF0000, .value = 0x80550000, - .num_devices = 6, + .num_devices = 7, .device_list = (enum ppc_sys_devices []) { MPC83xx_TSEC1, MPC83xx_TSEC2, MPC83xx_IIC1, MPC83xx_IIC2, MPC83xx_DUART, - MPC83xx_USB2_DR, + MPC83xx_USB2_DR, MPC83xx_USB2_MPH }, }, + { + .ppc_sys_name = "8343E", + .mask = 0xFFFF0000, + .value = 0x80560000, + .num_devices = 7, + .device_list = (enum ppc_sys_devices []) + { + MPC83xx_TSEC1, MPC83xx_TSEC2, MPC83xx_IIC1, + MPC83xx_IIC2, MPC83xx_DUART, MPC83xx_SEC2, + MPC83xx_USB2_DR + } + }, + { + .ppc_sys_name = "8343", + .mask = 0xFFFF0000, + .value = 0x80570000, + .num_devices = 6, + .device_list = (enum ppc_sys_devices []) + { + MPC83xx_TSEC1, MPC83xx_TSEC2, MPC83xx_IIC1, + MPC83xx_IIC2, MPC83xx_DUART, + MPC83xx_USB2_DR + } + }, { /* default match */ .ppc_sys_name = "", .mask = 0x00000000,
Quoted 5 lines · David Updegraff
Hi.
The PVRs are wrongly enumerated for the 8343/8343e chips.
-dbu
Good catch. I'll send a fixed up version of this patch upstream.
In the future take a look at Documentation/SubmittingPatches.
thanks
- kumar