kill_proc_info_as_uid: don't use hardcoded constants
PATCH 1/1 kill_proc_info_as_uid: don't use hardcoded constants
Use symbolic names instead of hardcoded constants.
Signed-off-by Oleg Nesterov <[email protected]>
kernel/signal.c renamed from kernel/signal.c~1_KUID +1 -2
@@ -1163,8 +1163,7 @@ int kill_proc_info_as_uid(int sig, struc ret = -ESRCH ; goto out_unlock; } -if ((!info || ((unsigned long )info !=1 && - (unsigned long )info !=2 &&SI_FROMUSER (info))) +if ((info ==SEND_SIG_NOINFO || (!is_si_special (info) &&SI_FROMUSER (info))) && (euid != p->suid) && (euid != p->uid) && (uid != p->suid) && (uid != p->uid)) { ret = -EPERM ;
Quoted 1 line · Oleg Nesterov
Use symbolic names instead of hardcoded constants.
I'm more than happy with that. Seems like the original code in check_kill_permission() was changed in a similar way after I made that _as_uid() function.
I don't think that I am a person with any say in the signal.c code,but in case of doubt:
Acked-by Harald Welte <[email protected]>
Quoted 14 lines
Signed-off-by Oleg Nesterov <[email protected]>kernel/signal.c renamed from kernel/signal.c~1_KUID +1
-2@@ -1163,8 +1163,7 @@ int kill_proc_info_as_uid(int sig, struc ret = -ESRCH ; goto out_unlock; } -if ((!info || ((unsigned long )info !=1 && - (unsigned long )info !=2 &&SI_FROMUSER (info))) +if ((info ==SEND_SIG_NOINFO || (!is_si_special (info) &&SI_FROMUSER (info))) && (euid != p->suid) && (euid != p->uid) && (uid != p->suid) && (uid != p->uid)) { ret = -EPERM ;
Signature · 4 lines
- Harald Welte <[email protected]> http://gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)