Skip to contentSkip to conversation

tty: n_gsm: support buggy modem

RFC In review Lars Poeschel 3 participants 5 messages Jan 7, 2014 – Jan 8, 2014 TTY layer and serial drivers

lore
Share & tools
lore
#0 lore raw

RFC 1/1 tty: n_gsm: support buggy modem

From: Lars Poeschel <[email protected]>

This is obiviously a bad patch. Do not merge it!
I have a GSM Modem (Quectel M95 Revision: M95AR01A11) that I have a problem with when using the n_gsm mux line discipline. After attaching the line discipline and opening a muxed channel, the open never returns. The problem is that the tty code waits for the TIOCM_CD flag to be set. According to the 3GPP TS 07.10 specification the modem can set this virtual flag by setting the DV bit in it's modem status control message. My modem sends the modem status command, but this DV bit is not set. With this patch the modem and the whole mux is working fine. Another way makeing all this work is setting the carrier_raised function to NULL. The tty code assumes that everything is alright then.
My question is: What could be the best way to support this modem in mailine kernel ? I do not see a way to detect this buggy modem inside the line discipline and use this patch's method as a work around then. But the detection would only be possible using AT command before the line discipline is attached or using the muxed channel after the mux is set up.

Thanks,
Lars
---

drivers/tty/n_gsm.c +1 -0
index c0f76da..a1a6f57 100644
@@ -1061,6 +1061,7 @@ static void gsm_process_modem(struct tty_struct *tty, struct gsm_dlci *dlci,
 		mlines |= TIOCM_RI;
 	if (modem & MDM_DV)
 		mlines |= TIOCM_CD;
+	mlines |= TIOCM_CD;
 
 	/* Carrier drop -> hangup */
 	if (tty) {
maintainer
#1 lore raw
Quoted 18 lines · Lars Poeschel

From: Lars Poeschel <[email protected]>

This is obiviously a bad patch. Do not merge it!
I have a GSM Modem (Quectel M95 Revision: M95AR01A11) that I have a problem with when using the n_gsm mux line discipline. After attaching the line discipline and opening a muxed channel, the open never returns. The problem is that the tty code waits for the TIOCM_CD flag to be set. According to the 3GPP TS 07.10 specification the modem can set this virtual flag by setting the DV bit in it's modem status control message. My modem sends the modem status command, but this DV bit is not set. With this patch the modem and the whole mux is working fine. Another way makeing all this work is setting the carrier_raised function to NULL. The tty code assumes that everything is alright then.
My question is: What could be the best way to support this modem in mailine kernel ? I do not see a way to detect this buggy modem inside the line discipline and use this patch's method as a work around then. But the detection would only be possible using AT command before the line discipline is attached or using the muxed channel after the mux is set up.

Adding some n_gsm.c authors to the cc:

Also, what kernel version are you using?

thanks,

greg k-h

Quoted 16 lines

Thanks,
Lars
---

drivers/tty/n_gsm.c +1 -0
index c0f76da..a1a6f57 100644
@@ -1061,6 +1061,7 @@ static void gsm_process_modem(struct tty_struct *tty, struct gsm_dlci *dlci,
 		mlines |= TIOCM_RI;
 	if (modem & MDM_DV)
 		mlines |= TIOCM_CD;
+	mlines |= TIOCM_CD;
 
 	/* Carrier drop -> hangup */
 	if (tty) {
#2 lore raw
Quoted 4 lines
Quoted 4 lines

modem status command, but this DV bit is not set. With this patch the modem and the whole mux is working fine. Another way makeing all this work is setting the carrier_raised function to NULL. The tty code assumes that everything is alright then.

Which means your modem has decided it doesn't yet have a carrier. Do you get a carrier after ATD completes with a CONNECTED message ?

(you can open with O_NDELAY to avoid blocking on the open)

Alan

#3 lore raw

Am Dienstag, 7. Januar 2014, 16:51:37 schrieb Alan Cox:

Quoted 10 lines
Quoted 5 lines
Quoted 5 lines

modem status command, but this DV bit is not set. With this patch the modem
and the whole mux is working fine. Another way makeing all this work is setting the carrier_raised function to NULL. The tty code assumes that everything is alright then.

Which means your modem has decided it doesn't yet have a carrier. Do you get a carrier after ATD completes with a CONNECTED message ?

(you can open with O_NDELAY to avoid blocking on the open)

Oh! Thank you! This does indeed bring up the channel. After opening nonblocking and writing ATD *99***1# to a muxed channel the modem sends a modem status command message with DV bit set.
This does in fact mean, I can only use the mux in nonblocking mode. Does this make sense ? Why can't I use a muxed channel with blocking IO ? I could do AT commands over the mux channel and the DV bit is not set (and thus TIOCM_CD is not set) and the modem (and the mux line discipline) is fine with it.

#4 lore raw
In reply to Greg KH

Am Dienstag, 7. Januar 2014, 06:20:50 schrieb Greg KH:

Quoted 23 lines · Lars Poeschel
Quoted 13 lines

From: Lars Poeschel <[email protected]>

This is obiviously a bad patch. Do not merge it!
I have a GSM Modem (Quectel M95 Revision: M95AR01A11) that I have a problem
with when using the n_gsm mux line discipline. After attaching the line discipline and opening a muxed channel, the open never returns. The problem is that the tty code waits for the TIOCM_CD flag to be set. According to the 3GPP TS 07.10 specification the modem can set this virtual flag by setting the DV bit in it's modem status control message. My modem sends the modem status command, but this DV bit is not set. With this patch the modem and the whole mux is working fine. Another way makeing all this work is setting the carrier_raised function to NULL. The

Quoted 8 lines

tty code assumes that everything is alright then.
My question is: What could be the best way to support this modem in mailine
kernel ? I do not see a way to detect this buggy modem inside the line discipline and use this patch's method as a work around then. But the detection would only be possible using AT command before the line discipline is attached or using the muxed channel after the mux is set up.

Quoted 3 lines

Adding some n_gsm.c authors to the cc:

Also, what kernel version are you using?

Sorry, I forgot this.
I am using 3.12. After your mail I tried 3.13-rc7. It behaves exactly the same.

Quoted 17 lines
Quoted 17 lines

---

drivers/tty/n_gsm.c +1 -0
index c0f76da..a1a6f57 100644
@@ -1061,6 +1061,7 @@ static void gsm_process_modem(struct tty_struct
 *tty, struct gsm_dlci *dlci,> 
 		mlines |= TIOCM_RI;
 
 	if (modem & MDM_DV)
 
 		mlines |= TIOCM_CD;
 
+	mlines |= TIOCM_CD;
 
 	/* Carrier drop -> hangup */
 	if (tty) {