Skip to contentSkip to conversation

nvidiafb: Driver cleanup

PATCH In review Antonino A. Daplas 1 participant 1 message Nov 30, 2005 Framebuffer layer

lore
Share & tools
lore

Antonino A. Daplas

author
#0 lore raw

PATCH 1/16 nvidiafb: Driver cleanup

- remove redundant casts
- add mode_option to module parameter

Signed-off-by Antonino Daplas <[email protected]>

---

 drivers/video/nvidia/nv_i2c.c |    6 +++---
 drivers/video/nvidia/nvidia.c |    7 +++++--
 2 files changed, 8 insertions(+), 5 deletions(-)
drivers/video/nvidia/nv_i2c.c +3 -3
index fa72472..bd9eca0 100644
@@ -46,7 +46,7 @@ static void nvidia_gpio_setscl(void *dat
 
 static void nvidia_gpio_setsda(void *data, int state)
 {
-	struct nvidia_i2c_chan *chan = (struct nvidia_i2c_chan *)data;
+	struct nvidia_i2c_chan *chan = data;
 	struct nvidia_par *par = chan->par;
 	u32 val;
 

@@ -64,7 +64,7 @@ static void nvidia_gpio_setsda(void *dat
 
 static int nvidia_gpio_getscl(void *data)
 {
-	struct nvidia_i2c_chan *chan = (struct nvidia_i2c_chan *)data;
+	struct nvidia_i2c_chan *chan = data;
 	struct nvidia_par *par = chan->par;
 	u32 val = 0;
 

@@ -79,7 +79,7 @@ static int nvidia_gpio_getscl(void *data
 
 static int nvidia_gpio_getsda(void *data)
 {
-	struct nvidia_i2c_chan *chan = (struct nvidia_i2c_chan *)data;
+	struct nvidia_i2c_chan *chan = data;
 	struct nvidia_par *par = chan->par;
 	u32 val = 0;
drivers/video/nvidia/nvidia.c +5 -2
index bee09c6..961007d 100644
@@ -485,7 +485,7 @@ static int nvidia_backlight_levels[] = {
 
 static int nvidia_set_backlight_enable(int on, int level, void *data)
 {
-	struct nvidia_par *par = (struct nvidia_par *)data;
+	struct nvidia_par *par = data;
 	u32 tmp_pcrt, tmp_pmc, fpcontrol;
 
 	tmp_pmc = NV_RD32(par->PMC, 0x10F0) & 0x0000FFFF;

@@ -1513,7 +1513,7 @@ static int __devinit nvidiafb_probe(stru
 	if (!info)
 		goto err_out;
 
-	par = (struct nvidia_par *)info->par;
+	par = info->par;
 	par->pci_dev = pd;
 
 	info->pixmap.addr = kmalloc(8 * 1024, GFP_KERNEL);

@@ -1804,6 +1804,9 @@ module_param(vram, int, 0);
 MODULE_PARM_DESC(vram,
 		 "amount of framebuffer memory to remap in MiB"
 		 "(default=0 - remap entire memory)");
+module_param(mode_option, charp, 0);
+MODULE_PARM_DESC(mode_option, "Specify initial video mode");
+
 #ifdef CONFIG_MTRR
 module_param(nomtrr, bool, 0);
 MODULE_PARM_DESC(nomtrr, "Disables MTRR support (0 or 1=disabled) "

-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click