polling loops: change exit condition to

PATCH In review Marcin Slusarz 3 participants 4 messages Dec 4, 2005 – Dec 5, 2005

Subsystems (2)

PowerPC Kernel janitors

lore

Share & tools

lore

Marcin Slusarz

author

2005-12-04 00:12 UTC #0 lore raw

PATCH 1/21 polling loops: change exit condition to

hello everyone
here is the first part of patch which changes many polling loops to use jiffies and time_after / time_before instead of counters most of the changes are in drivers directory (except first patch) as it is my first patch for linux kernel, feel free to point out any mistake you'll find

(this task is the last entry of kernel-janitors todo: http://janitor.kernelnewbies.org/TODO)

LINUX FOR POWER MACINTOSH
P: Benjamin Herrenschmidt
M: [email protected]

Signed-off-by Marcin Slusarz <[email protected]>

arch/ppc/platforms/pmac_smp.c +2 -3

diff -upr -X linux-2.6.15-rc4/Documentation/dontdiff linux-2.6.15-rc4-orig/arch/ppc/platforms/pmac_smp.c linux-2.6.15-rc4/arch/ppc/platforms/pmac_smp.c
@@ -675,11 +675,10 @@ void cpu_die(void)
 
 void __cpu_die(unsigned int cpu)
 {
-	int timeout;
+	unsigned long end_time = jiffies + msecs_to_jiffies(1000);
 
-	timeout = 1000;
 	while (!cpu_dead[cpu]) {
-		if (--timeout = 0) {
+		if (time_after(jiffies, end_time)) {
 			printk("CPU %u refused to die!\n", cpu);
 			break;
 		}

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Arnd Bergmann

2005-12-04 19:57 UTC #1 lore raw

Am Sonntag 04 Dezember 2005 01:12 schrieb Marcin Slusarz:

Quoted 6 lines

hello everyone
here is the first part of patch which changes many polling loops to use jiffies and time_after / time_before instead of counters most of the changes are in drivers directory (except first patch) as it is my first patch for linux kernel, feel free to point out any mistake you'll find

Hmm, what happened to the poll_event API that Nish had suggested some time ago for this problem? Was there an actual reason against merging it or did the patch just get lost?

	Arnd <><

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Nishanth Aravamudan

2005-12-04 20:18 UTC #2 lore raw

In reply to Marcin Slusarz

Quoted 11 lines · Arnd Bergmann

Am Sonntag 04 Dezember 2005 01:12 schrieb Marcin Slusarz:
Quoted 6 lines
hello everyone
here is the first part of patch which changes many polling loops to use jiffies and time_after / time_before instead of counters most of the changes are in drivers directory (except first patch) as it is my first patch for linux kernel, feel free to point out any mistake you'll find
Hmm, what happened to the poll_event API that Nish had suggested some time ago for this problem? Was there an actual reason against merging it or did the patch just get lost?

A good question. I'll try to dig up my patch from my old machine and take a look if it can be used instead of all these changes.

Thanks,
Nish

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Marcin Slusarz

author

2005-12-05 17:12 UTC #3 lore raw

Re: [KJ] [PATCH 1/21] polling loops: change exit condition

In reply to Marcin Slusarz

Quoted 6 lines · Nishanth Aravamudan

Quoted 6 lines
Quoted 5 lines
here is the first part of patch which changes many polling loops to use jiffies and time_after / time_before instead of counters most of the changes are in drivers directory (except first patch) as it is my first patch for linux kernel, feel free to point out any mistake you'll find

Quoted 7 lines

Quoted 3 lines
Hmm, what happened to the poll_event API that Nish had suggested some time ago for this problem? Was there an actual reason against merging it or did the patch just get lost?
A good question. I'll try to dig up my patch from my old machine and take a look if it can be used instead of all these changes.

i think you ment "with", not "instead" ;)
in my ("kernel newbie" ;) humble opinion these macros make code harder too read

(last version of your patch i found is here:
http://lists.osdl.org/pipermail/kernel-janitors/2005-March/003699.html)

regards,
Marcin
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors