Skip to contentSkip to conversation

fix typos around 16550A driver

PATCH Applied Jan Kiszka 2 participants 2 messages Dec 17, 2005

lore
Share & tools
lore

Jan Kiszka

author
#0 lore raw

PATCH 1/1 fix typos around 16550A driver

Hi,

these are two typo fixes for the serial driver. One of them should have broken kernel 2.4 compilation for this driver, the other is cosmetic

Jan

PS: What about this splnone in gatekeeper_thread(), BTW. Still needed?

nucleus/shadow.c (Arbeitskopie) renamed from nucleus/shadow.c (Revision 285) +0 -1
@@ -384,7 +384,6 @@
        set_current_state(TASK_INTERRUPTIBLE);
        up(&gk->sync); /* Make the request token available. */
        schedule();
-       splnone();
 
        if (kthread_should_stop())
            break;
drivers/16550A/16550A.c +1 -1
Index: ksrc/drivers/16550A/16550A.c
===================================================================
@@ -1025,7 +1025,7 @@
 
     device_class:       RTDM_CLASS_SERIAL,
     device_sub_class:   RTDM_SUBCLASS_16550A,
-    driver_name:        "rt_16550A",
+    driver_name:        "xeno_16550A",
     driver_version:     RTDM_DRIVER_VER(1, 2, 1),
     peripheral_name:    "UART 16550A",
     provider_name:      "Jan Kiszka",
drivers/16550A/Makefile +1 -1
Index: ksrc/drivers/16550A/Makefile
===================================================================
@@ -12,7 +12,7 @@
 
 O_TARGET := built-in.o
 
-obj-$(CONFIG_XENO_SKIN_16550A) := xeno_16550A.o
+obj-$(CONFIG_XENO_DRIVERS_16550A) := xeno_16550A.o
 
 list-multi := xeno_16550A.o
 
#1 lore raw
Quoted 5 lines · Jan Kiszka

Hi,

these are two typo fixes for the serial driver. One of them should have broken kernel 2.4 compilation for this driver, the other is cosmetic

Applied, thanks.

Quoted 5 lines

Jan

PS: What about this splnone in gatekeeper_thread(), BTW. Still needed?

Nope. Fixed.

Quoted 48 lines
nucleus/shadow.c (Arbeitskopie) renamed from nucleus/shadow.c (Revision 285) +0 -2
@@ -384,7 +384,6 @@
        set_current_state(TASK_INTERRUPTIBLE);
        up(&gk->sync); /* Make the request token available. */
        schedule();
-       splnone();
 
        if (kthread_should_stop())
            break;
 
 
------------------------------------------------------------------------

Index: ksrc/drivers/16550A/16550A.c
===================================================================

drivers/16550A/16550A.c +1 -1
@@ -1025,7 +1025,7 @@
 
     device_class:       RTDM_CLASS_SERIAL,
     device_sub_class:   RTDM_SUBCLASS_16550A,
-    driver_name:        "rt_16550A",
+    driver_name:        "xeno_16550A",
     driver_version:     RTDM_DRIVER_VER(1, 2, 1),
     peripheral_name:    "UART 16550A",
     provider_name:      "Jan Kiszka",

Index: ksrc/drivers/16550A/Makefile
===================================================================

drivers/16550A/Makefile +1 -2
@@ -12,7 +12,7 @@
 
 O_TARGET := built-in.o
 
-obj-$(CONFIG_XENO_SKIN_16550A) := xeno_16550A.o
+obj-$(CONFIG_XENO_DRIVERS_16550A) := xeno_16550A.o
 
 list-multi := xeno_16550A.o
 
 
 
------------------------------------------------------------------------

_______________________________________________
Xenomai-core mailing list
[email protected]
https://mail.gna.org/listinfo/xenomai-core

Signature · 1 line
Philippe.