Badness in as_insert_request at drivers/block/as-iosched.c:1519
Hiya all,
I was just playing a cd as usual and i noticed suddenly the errors below, they repeated like 8 times.
kernel: 2.6.14.5
Jan 7 14:32:40 localhost kernel: Badness in as_insert_request at drivers/block/as-iosched.c:1519
Jan 7 14:32:40 localhost kernel: [as_insert_request+100/384] Jan 7 14:32:40 localhost kernel: [__elv_add_request+120/192] Jan 7 14:32:40 localhost kernel: [elv_add_request+76/112] Jan 7 14:32:40 localhost kernel: [blk_execute_rq_nowait+72/96] Jan 7 14:32:40 localhost kernel: [blk_execute_rq+148/192] Jan 7 14:32:40 localhost kernel: [blk_end_sync_rq+0/64] Jan 7 14:32:40 localhost kernel: [blk_rq_bio_prep+115/160] Jan 7 14:32:40 localhost kernel: [cdrom_read_cdda_bpc+391/496] Jan 7 14:32:40 localhost kernel: [cdrom_read_cdda+68/176] Jan 7 14:32:40 localhost kernel: [mmc_ioctl+1373/2752] Jan 7 14:32:40 localhost kernel: [cdrom_read_cdda+68/176] Jan 7 14:32:40 localhost kernel: [mmc_ioctl+1373/2752] Jan 7 14:32:40 localhost kernel: [scsi_cmd_ioctl+125/1232] Jan 7 14:32:40 localhost last message repeated 3 times Jan 7 14:32:40 localhost kernel: [cdrom_ioctl+3228/3392] Jan 7 14:32:40 localhost kernel: [activate_task+141/160] Jan 7 14:32:40 localhost kernel: [try_to_wake_up+730/832] Jan 7 14:32:40 localhost kernel: [idecd_ioctl+133/144] Jan 7 14:32:40 localhost kernel: [blkdev_driver_ioctl+82/144] Jan 7 14:32:40 localhost kernel: [blkdev_ioctl+168/432] Jan 7 14:32:40 localhost kernel: [block_ioctl+43/48] Jan 7 14:32:40 localhost kernel: [do_ioctl+142/160] Jan 7 14:32:40 localhost kernel: [vfs_ioctl+101/496] Jan 7 14:32:40 localhost kernel: [sys_ioctl+103/144] Jan 7 14:32:40 localhost kernel: [syscall_call+7/11] Jan 7 14:32:40 localhost kernel: arq->state: 4
Appreciate it if any one can take a look.
Thanks,
Mark
Quoted 37 lines · Mark v Wolher
Hiya all,
I was just playing a cd as usual and i noticed suddenly the errors below, they repeated like 8 times.
kernel: 2.6.14.5
Jan 7 14:32:40 localhost kernel: Badness in
as_insert_requestatdrivers/block/as-iosched.c:1519
Jan 7 14:32:40 localhost kernel: [as_insert_request+100/384] Jan 7 14:32:40 localhost kernel: [__elv_add_request+120/192] Jan 7 14:32:40 localhost kernel: [elv_add_request+76/112] Jan 7 14:32:40 localhost kernel: [blk_execute_rq_nowait+72/96] Jan 7 14:32:40 localhost kernel: [blk_execute_rq+148/192] Jan 7 14:32:40 localhost kernel: [blk_end_sync_rq+0/64] Jan 7 14:32:40 localhost kernel: [blk_rq_bio_prep+115/160] Jan 7 14:32:40 localhost kernel: [cdrom_read_cdda_bpc+391/496] Jan 7 14:32:40 localhost kernel: [cdrom_read_cdda+68/176] Jan 7 14:32:40 localhost kernel: [mmc_ioctl+1373/2752] Jan 7 14:32:40 localhost kernel: [cdrom_read_cdda+68/176] Jan 7 14:32:40 localhost kernel: [mmc_ioctl+1373/2752] Jan 7 14:32:40 localhost kernel: [scsi_cmd_ioctl+125/1232] Jan 7 14:32:40 localhost last message repeated 3 times Jan 7 14:32:40 localhost kernel: [cdrom_ioctl+3228/3392] Jan 7 14:32:40 localhost kernel: [activate_task+141/160] Jan 7 14:32:40 localhost kernel: [try_to_wake_up+730/832] Jan 7 14:32:40 localhost kernel: [idecd_ioctl+133/144] Jan 7 14:32:40 localhost kernel: [blkdev_driver_ioctl+82/144] Jan 7 14:32:40 localhost kernel: [blkdev_ioctl+168/432] Jan 7 14:32:40 localhost kernel: [block_ioctl+43/48] Jan 7 14:32:40 localhost kernel: [do_ioctl+142/160] Jan 7 14:32:40 localhost kernel: [vfs_ioctl+101/496] Jan 7 14:32:40 localhost kernel: [sys_ioctl+103/144] Jan 7 14:32:40 localhost kernel: [syscall_call+7/11] Jan 7 14:32:40 localhost kernel:arq->state: 4
Quoted 6 lines
Appreciate it if any one can take a look.
Thanks,
Mark
-
I have 2 drives, when i put the same cd or other cd's in the other drive then nothing happens. It happens only with the other drive.
Which is this one:
Model=DVDRW DRW-1S45, FwRev=GBG2, SerialNo=
Config={ Fixed Removeable DTR<=5Mbs DTR>10Mbs nonMagnetic } RawCHS=0/0/0, TrkSize=0, SectSize=0, ECCbytes=0 BuffType=unknown, BuffSize=0kB, MaxMultSect=0 (maybe): CurCHS=0/0/0, CurSects=0, LBA=yes, LBAsects=0 IORDY=yes, tPIO={min:227,w/IORDY:120}, tDMA={min:120,rec:120} PIO modes: pio0 pio1 pio2 pio3 pio4
DMA modes: mdma0 mdma1 mdma2
UDMA modes: udma0 udma1 *udma2
AdvancedPM=no
Drive conforms to: device does not report version:
* signifies the current active mode
Quoted 6 lines · Mark v Wolher
Hiya all,
I was just playing a cd as usual and i noticed suddenly the errors below, they repeated like 8 times.
kernel: 2.6.14.5
Should be fixed in newer 2.6.14.x, and in 2.6.15.
Signature · 1 line
Jens Axboe
Quoted 64 lines · Mark v Wolher
Quoted 37 lines · Mark v Wolher
Hiya all,
I was just playing a cd as usual and i noticed suddenly the errors below, they repeated like 8 times.
kernel: 2.6.14.5
Jan 7 14:32:40 localhost kernel: Badness in
as_insert_requestatdrivers/block/as-iosched.c:1519
Jan 7 14:32:40 localhost kernel: [as_insert_request+100/384] Jan 7 14:32:40 localhost kernel: [__elv_add_request+120/192] Jan 7 14:32:40 localhost kernel: [elv_add_request+76/112] Jan 7 14:32:40 localhost kernel: [blk_execute_rq_nowait+72/96] Jan 7 14:32:40 localhost kernel: [blk_execute_rq+148/192] Jan 7 14:32:40 localhost kernel: [blk_end_sync_rq+0/64] Jan 7 14:32:40 localhost kernel: [blk_rq_bio_prep+115/160] Jan 7 14:32:40 localhost kernel: [cdrom_read_cdda_bpc+391/496] Jan 7 14:32:40 localhost kernel: [cdrom_read_cdda+68/176] Jan 7 14:32:40 localhost kernel: [mmc_ioctl+1373/2752] Jan 7 14:32:40 localhost kernel: [cdrom_read_cdda+68/176] Jan 7 14:32:40 localhost kernel: [mmc_ioctl+1373/2752] Jan 7 14:32:40 localhost kernel: [scsi_cmd_ioctl+125/1232] Jan 7 14:32:40 localhost last message repeated 3 times Jan 7 14:32:40 localhost kernel: [cdrom_ioctl+3228/3392] Jan 7 14:32:40 localhost kernel: [activate_task+141/160] Jan 7 14:32:40 localhost kernel: [try_to_wake_up+730/832] Jan 7 14:32:40 localhost kernel: [idecd_ioctl+133/144] Jan 7 14:32:40 localhost kernel: [blkdev_driver_ioctl+82/144] Jan 7 14:32:40 localhost kernel: [blkdev_ioctl+168/432] Jan 7 14:32:40 localhost kernel: [block_ioctl+43/48] Jan 7 14:32:40 localhost kernel: [do_ioctl+142/160] Jan 7 14:32:40 localhost kernel: [vfs_ioctl+101/496] Jan 7 14:32:40 localhost kernel: [sys_ioctl+103/144] Jan 7 14:32:40 localhost kernel: [syscall_call+7/11] Jan 7 14:32:40 localhost kernel:arq->state: 4Quoted 6 lines
Appreciate it if any one can take a look.
Thanks,
Mark
-I have 2 drives, when i put the same cd or other cd's in the other drive then nothing happens. It happens only with the other drive.
Which is this one:
Model=DVDRW DRW-1S45, FwRev=GBG2, SerialNo=
Config={ Fixed Removeable DTR<=5Mbs DTR>10Mbs nonMagnetic } RawCHS=0/0/0, TrkSize=0, SectSize=0, ECCbytes=0 BuffType=unknown, BuffSize=0kB, MaxMultSect=0 (maybe): CurCHS=0/0/0, CurSects=0, LBA=yes, LBAsects=0 IORDY=yes, tPIO={min:227,w/IORDY:120}, tDMA={min:120,rec:120} PIO modes: pio0 pio1 pio2 pio3 pio4
DMA modes: mdma0 mdma1 mdma2
UDMA modes: udma0 udma1 *udma2
AdvancedPM=no
Drive conforms to: device does not report version:
Quoted 6 lines
* signifies the current active mode
I went to /usr/src/linux/drivers/block/as-iosched.c line 1519, it's located in this function, anyone know what arq is ?
static voidas_insert_request(request_queue_t *q, struct request *rq, int where)
{
struct as_data *ad = q->elevator->elevator_data;
struct as_rq *arq = RQ_DATA(rq);
if (arq) {
if (arq->state != AS_RQ_PRESCHED) {
printk("arq->state: %d\n", arq->state);
WARN_ON(1); <<======= line 1519
}
arq->state = AS_RQ_NEW;
}
/* barriers must flush the reorder queue */
if (unlikely(rq->flags & (REQ_SOFTBARRIER | REQ_HARDBARRIER)
&& where == ELEVATOR_INSERT_SORT)) {
WARN_ON(1);
where = ELEVATOR_INSERT_BACK;
}
switch (where) {
case ELEVATOR_INSERT_BACK:
while (ad->next_arq[REQ_SYNC])
as_move_to_dispatch(ad,ad->next_arq[REQ_SYNC]);
while (ad->next_arq[REQ_ASYNC])
as_move_to_dispatch(ad,ad->next_arq[REQ_ASYNC]);
list_add_tail(&rq->queuelist, ad->dispatch);
as_account_queued_request(ad, rq);
as_antic_stop(ad);
break;
case ELEVATOR_INSERT_FRONT:
list_add(&rq->queuelist, ad->dispatch);
as_account_queued_request(ad, rq);
as_antic_stop(ad);
break;
case ELEVATOR_INSERT_SORT:
BUG_ON(!blk_fs_request(rq));
as_add_request(ad, arq);
break;
default:
BUG();
return;
}
}Quoted 4 lines · Jens Axboe
Quoted 2 lines · Mark v Wolher
Hiya all,
Quoted 8 lines
Quoted 4 lines
I was just playing a cd as usual and i noticed suddenly the errors below, they repeated like 8 times.
kernel: 2.6.14.5
Should be fixed in newer 2.6.14.x, and in 2.6.15.
Looks like it isn't :( , well in 2.6.14.5
Quoted 8 lines · Mark v Wolher
Quoted 7 lines · Jens Axboe
Quoted 5 lines · Mark v Wolher
Hiya all,
I was just playing a cd as usual and i noticed suddenly the errors below, they repeated like 8 times.
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
kernel: 2.6.14.5
Should be fixed in newer 2.6.14.x, and in 2.6.15.
Looks like it isn't :( , well in 2.6.14.5
Oh, indeed. 2.6.15 has it fixed though. For 2.6.14.5 you have two choices:
1) Delete the warning from as-iosched.c. It's harmless, it doesn't indicate a bug in this case.
2) Apply this attached patch to prevent cdrom.c from reusing a request when doing single frame cdda dma.
drivers/cdrom/cdrom.c +10 -6
@@ -2089,7 +2089,7 @@ static int cdrom_read_cdda_bpc(struct cd int lba, int nframes) {request_queue_t *q = cdi->disk->queue; -struct request *rq; +struct request *rq =NULL ;struct bio *bio;unsigned int len;int nr, ret =0 ;
@@ -2097,13 +2097,13 @@ static int cdrom_read_cdda_bpc(struct cdif (!q)return -ENXIO ; - rq =blk_get_request (q,READ ,GFP_KERNEL ); -if (!rq) -return -ENOMEM ; - cdi->last_sense =0 ;while (nframes) { + rq =blk_get_request (q,READ ,GFP_KERNEL ); +if (!rq) +return -ENOMEM ; + nr = nframes;if (cdi->cdda_method ==CDDA_BPC_SINGLE ) nr =1 ;
@@ -2151,9 +2151,13 @@ static int cdrom_read_cdda_bpc(struct cd nframes -= nr; lba += nr; ubuf += len; +blk_put_request (rq); + rq =NULL ; } -blk_put_request (rq); +if (rq) +blk_put_request (rq); +return ret; }
Signature · 1 line
Jens Axboe
Quoted 67 lines · Jens Axboe
Quoted 10 lines · Mark v Wolher
Quoted 8 lines · Jens Axboe
Quoted 5 lines · Mark v Wolher
Hiya all,
I was just playing a cd as usual and i noticed suddenly the errors below, they repeated like 8 times.
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
kernel: 2.6.14.5
Should be fixed in newer 2.6.14.x, and in 2.6.15.
Looks like it isn't :( , well in 2.6.14.5
Oh, indeed. 2.6.15 has it fixed though. For 2.6.14.5 you have two choices:
1) Delete the warning from
as-iosched.c. It's harmless, it doesn't indicate a bug in this case.2) Apply this attached patch to prevent
cdrom.cfrom reusing a request when doing single frame cdda dma.drivers/cdrom/cdrom.c +6
-5@@ -2089,7 +2089,7 @@ static int cdrom_read_cdda_bpc(struct cd int lba, int nframes) {request_queue_t *q = cdi->disk->queue; -struct request *rq; +struct request *rq =NULL ;struct bio *bio;unsigned int len;int nr, ret =0 ;@@ -2097,13 +2097,13 @@ static int cdrom_read_cdda_bpc(struct cdif (!q)return -ENXIO ; - rq =blk_get_request (q,READ ,GFP_KERNEL ); -if (!rq) -return -ENOMEM ; - cdi->last_sense =0 ;while (nframes) { + rq =blk_get_request (q,READ ,GFP_KERNEL ); +if (!rq) +return -ENOMEM ; + nr = nframes;if (cdi->cdda_method ==CDDA_BPC_SINGLE ) nr =1 ;@@ -2151,9 +2151,13 @@ static int cdrom_read_cdda_bpc(struct cd nframes -= nr; lba += nr; ubuf += len; +blk_put_request (rq);
drivers/cdrom/cdrom.c static int cdrom_read_cdda_bpc(struct cd · line 2163
Quoted 10 lines
drivers/cdrom/cdrom.c +4
-1+ rq =NULL ; } -blk_put_request (rq); +if (rq) +blk_put_request (rq); +return ret; }
Ah ok, thanks alot mate ! I think i'll patch it until i switch to 2.6.15.
Thanks again !
Mark