rcu: don't set ->next_pending in rcu_start_batch()
PATCH 3/5 rcu: don't set ->next_pending in rcu_start_batch()
I think it is better to set ->next_pending in the caller, when it is needed. This saves one parameter, and this coincides with cpu_quiet() beahaviour, which sets ->completed = ->cur itself.
Signed-off-by Oleg Nesterov <[email protected]>
kernel/rcupdate.c renamed from kernel/rcupdate.c~3_NPEND +4 -7
@@ -249,12 +249,8 @@ static void rcu_do_batch(struct rcu_data* active batch and the batch to be registered has not already occurred. * Caller must hold rcu_state.lock. */ -static void rcu_start_batch (struct rcu_ctrlblk *rcp,struct rcu_state *rsp, -int next_pending) +static void rcu_start_batch (struct rcu_ctrlblk *rcp,struct rcu_state *rsp) { -if (next_pending) - rcp->next_pending =1 ; -if (rcp->next_pending && rcp->completed == rcp->cur) { rcp->next_pending =0 ;
@@ -288,7 +284,7 @@ static void cpu_quiet(int cpu, struct rcif (cpus_empty (rsp->cpumask)) {/* batch completed ! */ rcp->completed = rcp->cur; -rcu_start_batch (rcp, rsp,0 ); +rcu_start_batch (rcp, rsp); } }
@@ -423,7 +419,8 @@ static void __rcu_process_callbacks(struif (!rcp->next_pending) {/* and start it/schedule start if it's a new batch */ spin_lock (&rsp->lock); -rcu_start_batch (rcp, rsp,1 ); + rcp->next_pending =1 ; +rcu_start_batch (rcp, rsp);spin_unlock (&rsp->lock); } }else {
Quoted 3 lines · Oleg Nesterov
I think it is better to set ->next_pending in the caller, when it is needed. This saves one parameter, and this coincides with
cpu_quiet()beahaviour, which sets ->completed = ->cur itself.
Makes sense to me!
Thanx, Paul
Acked-by Paul E. McKenney <[email protected]>
Quoted 38 lines
Signed-off-by Oleg Nesterov <[email protected]>kernel/rcupdate.c renamed from kernel/rcupdate.c~3_NPEND +4
-7@@ -249,12 +249,8 @@ static void rcu_do_batch(struct rcu_data* active batch and the batch to be registered has not already occurred. * Caller must hold rcu_state.lock. */ -static void rcu_start_batch (struct rcu_ctrlblk *rcp,struct rcu_state *rsp, -int next_pending) +static void rcu_start_batch (struct rcu_ctrlblk *rcp,struct rcu_state *rsp) { -if (next_pending) - rcp->next_pending =1 ; -if (rcp->next_pending && rcp->completed == rcp->cur) { rcp->next_pending =0 ;@@ -288,7 +284,7 @@ static void cpu_quiet(int cpu, struct rcif (cpus_empty (rsp->cpumask)) {/* batch completed ! */ rcp->completed = rcp->cur; -rcu_start_batch (rcp, rsp,0 ); +rcu_start_batch (rcp, rsp); } }@@ -423,7 +419,8 @@ static void __rcu_process_callbacks(struif (!rcp->next_pending) {/* and start it/schedule start if it's a new batch */ spin_lock (&rsp->lock); -rcu_start_batch (rcp, rsp,1 ); + rcp->next_pending =1 ; +rcu_start_batch (rcp, rsp);spin_unlock (&rsp->lock); } }else {