Skip to contentSkip to conversation

Fix PCI irq mapping for lite5200

kernel-2.6.15 Andrey Volkov 2 participants 2 messages Jan 12, 2006

lore
Share & tools
lore
#0 lore raw

Hi Sylvain,

This patch fix problem of PCI boards irq mapping on lite5200 (raised after your changes of MPC52xx_IRQ0 number)

--
Regards
Andrey Volkov

lite5200_map_irq: Fix irq mapping for external PCI boards

---

 arch/ppc/platforms/lite5200.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
arch/ppc/platforms/lite5200.c +2 -1
index 7ed52dc..cd4acb3 100644
@@ -73,7 +73,8 @@ lite5200_show_cpuinfo(struct seq_file *m
 static int
 lite5200_map_irq(struct pci_dev *dev, unsigned char idsel, unsigned char pin)
 {
-	return (pin == 1) && (idsel==24) ? MPC52xx_IRQ0 : -1;
+	/* Only INTA supported */
+	return (pin == 1) ? MPC52xx_IRQ0 : -1;
 }
 #endif
 
#1 lore raw

Hi Andrey,

Quoted 3 lines · Andrey Volkov

Hi Sylvain,

This patch fix problem of PCI boards irq mapping on lite5200

What problem is that patch supposed to fix ?
The Lite5200 has a single PCI port, assigned to idsel 24 (afair) and its INTA is connected to the IRQ0 pin of the 5200 so that looks correct to me.

Quoted 1 line

(raised after your changes of MPC52xx_IRQ0 number)

I'm not sure I get this either.
Do you mean that change provoked the bug you're talking about or that before that change the bug was there but just not visible because masked by the interrupt number being 0 problem ?

Sylvain

Quoted 30 lines

--
Regards
Andrey Volkov

------------------------------------------------------------------------

lite5200_map_irq: Fix irq mapping for external PCI boards

---

 arch/ppc/platforms/lite5200.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
arch/ppc/platforms/lite5200.c +2 -1
index 7ed52dc..cd4acb3 100644
@@ -73,7 +73,8 @@ lite5200_show_cpuinfo(struct seq_file *m
 static int
 lite5200_map_irq(struct pci_dev *dev, unsigned char idsel, unsigned char pin)
 {
-	return (pin == 1) && (idsel==24) ? MPC52xx_IRQ0 : -1;
+	/* Only INTA supported */
+	return (pin == 1) ? MPC52xx_IRQ0 : -1;
 }
 #endif