Skip to contentSkip to conversation

UEAGLE : cosmetic

PATCH matthieu castet 1 participant 1 message Jan 14, 2006

Subsystems (3)
lore
Share & tools
lore

matthieu castet

author maintainer
#0 lore raw

Hi,

this patch correct a possible bug with cmv_name being static. If there is 2 modems and the driver is scheduled when filling cmv_name this could result with garbage in cmv_name. We allocate cmv_name on the stack but with a small size in order to avoid that.

drivers/usb/atm/ueagle-atm.c +1 -1
Index: Linux/drivers/usb/atm/ueagle-atm.c
===================================================================
@@ -1012,7 +1012,7 @@
 	int ret, size;
 	u8 *data;
 	char *file;
-	static char cmv_name[256] = FW_DIR;
+	char cmv_name[FIRMWARE_NAME_MAX]; /* 30 bytes stack variable */
 
 	if (cmv_file[sc->modem_index] == NULL) {
 		if (UEA_CHIP_VERSION(sc) == ADI930)