Skip to contentSkip to conversation

__LP64__ / CONFIG_64BIT?

parisc-linux Joel Soete 3 participants 4 messages Jan 15, 2006 – Jan 16, 2006

lore
Share & tools
lore
#1 lore raw
Quoted 4 lines · Joel Soete

Hello *,

Could we move all #ifdef __LP64__ to CONFIG_64BIT?

Er, why? One of them is shorter to write, and makes the same amount of sense... I have no particularly preference at any rate. In fact, using __LP64__ might be preferable, as CONFIG_64BIT requires us including <linux/config.h> which means any change to the config will cause this file to be rebuilt whether or not it is actually required. Then again, it's entirely possible my understanding of this config crap is antiquated.

Cheers,
Kyle
_______________________________________________
parisc-linux mailing list
[email protected]
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

#2 lore raw
Quoted 7 lines · Kyle McMartin

Er, why? One of them is shorter to write, and makes the same amount of sense... I have no particularly preference at any rate. In fact, using __LP64__ might be preferable, as CONFIG_64BIT requires us including <linux/config.h> which means any change to the config will cause this file to be rebuilt whether or not it is actually required. Then again, it's entirely possible my understanding of this config crap is antiquated.

Doubly antiquated, I'm afraid. Most recently, changes to the build system mean that including <linux/config.h> is a no-op. It's automatically included for the files that need it.

The earlier antiquation happened many, many years ago, and it was that the dependency writer (back in the days of 'make dep') treated <linux/config.h> specially. It scanned the file looking for CONFIG_* symbols and added dependencies on the autobuilt include/config/ directory (one file per config symbol).

I don't think we need to change from __LP64__ to CONFIG_64BIT overnight. I think CONFIG_64IT has meaning to people from a non-HP environment, so has slight clarity advantages. If you're touching some code that uses __LP64__, by all means do the conversion to CONFIG_64BIT, but don't do it unnecessarily.
_______________________________________________
parisc-linux mailing list [email protected]
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

#3 lore raw
Quoted 10 lines · Matthew Wilcox

Doubly antiquated, I'm afraid. Most recently, changes to the build system mean that including <linux/config.h> is a no-op. It's automatically included for the files that need it.

The earlier antiquation happened many, many years ago, and it was that the dependency writer (back in the days of 'make dep') treated <linux/config.h> specially. It scanned the file looking for CONFIG_* symbols and added dependencies on the autobuilt include/config/ directory (one file per config symbol).

Ok.

Quoted 6 lines

I don't think we need to change from __LP64__ to CONFIG_64BIT overnight. I think CONFIG_64IT has meaning to people from a non-HP environment, so has slight clarity advantages. If you're touching some code that uses __LP64__, by all means do the conversion to CONFIG_64BIT, but don't do it unnecessarily.

Fair enough.
_______________________________________________
parisc-linux mailing list
[email protected]
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux