Skip to contentSkip to conversation

drivers/block/ps2esdi.c

DISCUSSION Alejandro Bonilla Beeche 3 participants 4 messages Jan 16, 2006 Block layer

lore
Share & tools
lore
#0 lore raw

It looks like the Linux-2.6 tree is still broken...

Just FYI

CC drivers/block/loop.o
CC drivers/block/ps2esdi.o
In file included from drivers/block/ps2esdi.c:42:
include/linux/mca-legacy.h:12:2: warning: #warning "MCA legacy - please move your driver to the new sysfs api" drivers/block/ps2esdi.c: In function 'ps2esdi_getgeo':
drivers/block/ps2esdi.c:1064: error: dereferencing pointer to incomplete type drivers/block/ps2esdi.c:1065: error: dereferencing pointer to incomplete type drivers/block/ps2esdi.c:1066: error: dereferencing pointer to incomplete type
make[3]: *** [drivers/block/ps2esdi.o] Error 1
make[2]: *** [drivers/block] Error 2
make[1]: *** [drivers] Error 2
make[1]: Leaving directory `/root/linux-2.6'
make: *** [debian/stamp-build-kernel] Error 2
debian:~/linux-2.6#

#1 lore raw
Quoted 15 lines · Alejandro Bonilla Beeche

It looks like the Linux-2.6 tree is still broken...

Just FYI

CC drivers/block/loop.o
CC drivers/block/ps2esdi.o
In file included from drivers/block/ps2esdi.c:42:
include/linux/mca-legacy.h:12:2: warning: #warning "MCA legacy - please move your driver to the new sysfs api" drivers/block/ps2esdi.c: In function 'ps2esdi_getgeo':
drivers/block/ps2esdi.c:1064: error: dereferencing pointer to incomplete type
drivers/block/ps2esdi.c:1065: error: dereferencing pointer to incomplete type

Quoted 8 lines

drivers/block/ps2esdi.c:1066: error: dereferencing pointer to incomplete type
make[3]: *** [drivers/block/ps2esdi.o] Error 1
make[2]: *** [drivers/block] Error 2
make[1]: *** [drivers] Error 2
make[1]: Leaving directory `/root/linux-2.6'
make: *** [debian/stamp-build-kernel] Error 2 debian:~/linux-2.6#

As Adrian (IIRC) pointed out last time this was posted (last week), this is what you can get when you enable "BROKEN". IOW, see
drivers/block/Kconfig:

config BLK_DEV_PS2

	tristate "PS/2 ESDI hard disk support"
	depends on MCA && MCA_LEGACY && BROKEN
                                        ^^^^^^

so please send patches to fix it (the driver) if you care about it.

Signature · 1 line
~Randy
#2 lore raw
Quoted 30 lines · Randy.Dunlap
Quoted 15 lines · Alejandro Bonilla Beeche

It looks like the Linux-2.6 tree is still broken...

Just FYI

CC drivers/block/loop.o
CC drivers/block/ps2esdi.o
In file included from drivers/block/ps2esdi.c:42:
include/linux/mca-legacy.h:12:2: warning: #warning "MCA legacy - please move your driver to the new sysfs api" drivers/block/ps2esdi.c: In function 'ps2esdi_getgeo':
drivers/block/ps2esdi.c:1064: error: dereferencing pointer to incomplete type
drivers/block/ps2esdi.c:1065: error: dereferencing pointer to incomplete type

Quoted 8 lines

drivers/block/ps2esdi.c:1066: error: dereferencing pointer to incomplete type
make[3]: *** [drivers/block/ps2esdi.o] Error 1
make[2]: *** [drivers/block] Error 2
make[1]: *** [drivers] Error 2
make[1]: Leaving directory `/root/linux-2.6'
make: *** [debian/stamp-build-kernel] Error 2 debian:~/linux-2.6#

As Adrian (IIRC) pointed out last time this was posted (last week), this is what you can get when you enable "BROKEN". IOW, see
drivers/block/Kconfig:

Quoted 6 lines

config BLK_DEV_PS2

	tristate "PS/2 ESDI hard disk support"
	depends on MCA && MCA_LEGACY && BROKEN
                                        ^^^^^^

so please send patches to fix it (the driver) if you care about it.

Well this breakage is new though, Christoph looks like fallout from the geo stuff.

drivers/block/ps2esdi.c +1 -0
index 43415f6..bea75f2 100644
@@ -43,6 +43,7 @@
 #include <linux/init.h>
 #include <linux/ioport.h>
 #include <linux/module.h>
+#include <linux/hdreg.h>
 
 #include <asm/system.h>
 #include <asm/io.h>
Signature · 1 line
Jens Axboe
#3 lore raw
Quoted 8 lines · Jens Axboe
Quoted 7 lines · Randy.Dunlap
Quoted 5 lines · Alejandro Bonilla Beeche

It looks like the Linux-2.6 tree is still broken...

Just FYI

Quoted 7 lines
Quoted 4 lines
	depends on MCA && MCA_LEGACY && BROKEN
                                        ^^^^^^

so please send patches to fix it (the driver) if you care about it.

Well this breakage is new though, Christoph looks like fallout from the geo stuff.

Aha. Thanks.

Signature · 1 line
~Randy