Skip to contentSkip to conversation

Remove bogus assert

PATCH Applied Pierre Ossman 2 participants 2 messages Jan 25, 2006 – Jan 27, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove bogus assert

Freeing the global config update structure when it had been created without any configs present caused an assertion to trigger. Since this is a valid scenario and the assertion didn't really protect against anything, it should simply be removed. Attached patch does exactly that.

Rgds
Pierre

src/conf.c +0 -1
@@ -3106,7 +3106,6 @@
 	unsigned int k;
 
 	assert(update);
-	assert(update->count > 0 && update->finfo);
 	for (k = 0; k < update->count; k++)
 		free(update->finfo[k].name);
 	if (update->finfo)
Applied
#1 lore raw

At Wed, 25 Jan 2006 20:29:35 +0100,

Quoted 8 lines · Pierre Ossman

Freeing the global config update structure when it had been created without any configs present caused an assertion to trigger. Since this is a valid scenario and the assertion didn't really protect against anything, it should simply be removed. Attached patch does exactly that.

Rgds
Pierre

Thanks, applied to CVS now.

Takashi

-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642