Skip to contentSkip to conversation

hwmon-pc87360 : avoid lock & unlock when

PATCH New Jim Cromie 2 participants 2 messages Feb 6, 2006

lore
Share & tools
lore

Jim Cromie

author
#0 lore raw

PATCH 1/1 hwmon-pc87360 : avoid lock & unlock when

From: Jim Cromie <jim.cromie at gmail.com>

Modifies pc87360_update_device() to avoid locking & unlocking when data is not actually being resampled. Also re-indented the body of the function, removing the now extra tabs.

Signed-off-by Jim Cromie <jim.cromie at gmail.com>

----

patch applies over:
linux-2.6.16-rc1-mm4
+ hwmon-pc87360-use-sensor-attr-2.patch
+ hwmon-pc87360-sysfs-combo-callbacks.patch

or without the 2 patches, with (offset -34 lines).

$ diffstat hwmon-pc87360-lock-only-when-sampling.patch
 pc87360.c |  158 
+++++++++++++++++++++++++++++++-------------------------------
 1 files changed, 79 insertions(+), 79 deletions(-)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: hwmon-pc87360-lock-only-when-sampling.patch
Type: text/x-patch
Size: 6213 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20060206/ebddd2e9/hwmon-pc87360-lock-only-when-sampling-0001.bin

#1 lore raw

PATCH 1/1 hwmon-pc87360 : avoid lock & unlock

Hi Jim,

Quoted 3 lines · Jim Cromie

Modifies pc87360_update_device() to avoid locking & unlocking when data is not actually being resampled. Also re-indented the body of the function, removing the now extra tabs.

Imagine that two user-space processes read sysfs files and trigger the update, at the same time. With the original locking model, both processes will attempt to get the lock. One only (A) will succeed, while the other (B) will have to wait. (A) will then test the time condition, and update the data if needs be, then release the lock. At this point,
(B) will be granted the lock, and will get to test the time condition. As (A) just updated the timestamp, (B) will skip the update as intended, and release the lock immediately.

With your changes, (A) and (B) will test the time condition concurrently. If an update is needed, they will fight for the lock. (A) will get it and do the update, then release the lock. Then (B) will get it and do the update again! Then release the lock. So you actually had two consecutive updates, while the caching mecanism precisely tries to avoid this.

So this doesn't work, sorry.

--
Jean Delvare