Skip to contentSkip to conversation

net/pppoe.c: check return code of register_netdevice_notifier

KJ walter harms 1 participant 1 message Feb 9, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

check return code of register_netdevice_notifier.
do propper cleanup and say goodbye

drivers/net/pppoe.c renamed from drivers/net/pppoe.c.bak +4 -1
@@ -1126,7 +1126,16 @@
  	
  	dev_add_pack(&pppoes_ptype);
  	dev_add_pack(&pppoed_ptype);
-	register_netdevice_notifier(&pppoe_notifier);
+
+	err = register_netdevice_notifier(&pppoe_notifier);
+	if (err < 0) {
+		printk( KERN_WARNING "register_netdevice_notifier failed in 

%s\n",__FUNCTION__);
+ dev_remove_pack(&pppoed_ptype);
+ dev_remove_pack(&pppoes_ptype);
+ goto out_unregister_pppox_proto;
+ }
+
+
out:
return err;
out_unregister_pppox_proto:
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors