Skip to contentSkip to conversation

net/bonding/bond_main.c:check return code of

KJ walter harms 1 participant 1 message Feb 9, 2006

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

check return code of 'register_netdevice_notifier' note that the register_inetaddr_notifier is not checked.

drivers/net/bonding/bond_main.c renamed from drivers/net/bonding/bond_main.c.bak +8 -1
@@ -4893,7 +4893,14 @@
 	}
 
 	rtnl_unlock();
-	register_netdevice_notifier(&bond_netdev_notifier);
+
+	res = register_netdevice_notifier(&bond_netdev_notifier);
+
+	if (res < 0) {
+		printk( KERN_WARNING DRV_NAME" register_netdevice_notifier failed\n");
+		goto out_err;
+	}
+
 	register_inetaddr_notifier(&bond_inetaddr_notifier);
 
 	return 0;
drivers/net/bonding/bond_main.c renamed from drivers/net/bonding/bond_main.c.bak +8 -1
@@ -4893,7 +4893,14 @@
 	}
 
 	rtnl_unlock();
-	register_netdevice_notifier(&bond_netdev_notifier);
+
+	res = register_netdevice_notifier(&bond_netdev_notifier);
+
+	if (res < 0) {
+		printk( KERN_WARNING DRV_NAME" register_netdevice_notifier failed\n");
+		goto out_err;
+	}
+
 	register_inetaddr_notifier(&bond_inetaddr_notifier);
 
 	return 0;

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors