Skip to contentSkip to conversation

pdc_adma: Last Patch to pdc_adma breaks debug compile[Scanned]

PATCH New Seewer Philippe 1 participant 1 message Feb 13, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pdc_adma: Last Patch to pdc_adma breaks debug compile[Scanned]

The Last Patch (5. Nov. 05) to the sata pdc_adma driver removed nelem from adma_fill_sg and introduced ata_for_each_sg.

The Problem is that nelem was forgot to be removed from the contained VPRINTK too. The attached patch fixes this.

Patch applies against 2.6.15.1

---

--- linux-2.6.15.1/drivers/scsi/pdc_adma.c.orig 2006-02-08 09:03:15.000000000 +0100
+++ linux-2.6.15.1/drivers/scsi/pdc_adma.c 2006-02-08
09:04:32.000000000 +0100
@@ -322,8 +322,8 @@ static int adma_fill_sg(struct ata_queue

                        = (pFLAGS & pEND) ? 0 : cpu_to_le32(pp->pkt_dma
+ i + 4);
                i += 4;

- VPRINTK("PRD[%u] = (0x%lX, 0x%X)\n", nelem
- (unsigned long)addr, len);
+ VPRINTK("Current PRD = (0x%lX, 0x%X)\n",

+                       (unsigned long)addr, len);
        }
        return i;

}

drivers/scsi/pdc_adma.c renamed from drivers/scsi/pdc_adma.c.orig +2 -2
@@ -322,8 +322,8 @@ static int adma_fill_sg(struct ata_queue
 			= (pFLAGS & pEND) ? 0 : cpu_to_le32(pp->pkt_dma + i + 4);
 		i += 4;
 
-		VPRINTK("PRD[%u] = (0x%lX, 0x%X)\n", nelem
-					(unsigned long)addr, len);
+		VPRINTK("Current PRD = (0x%lX, 0x%X)\n",
+			(unsigned long)addr, len);
 	}
 	return i;
 }