Skip to contentSkip to conversation

arch/ppc/82xx_io/uart.c bug found

DISCUSSION Wojciech Kromer 2 participants 3 messages Feb 13, 2006 – Feb 20, 2006

lore
Share & tools
lore
#0 lore raw

here is orignal uart.c

#ifdef SCC_CONSOLE
                               switch (state->smc_scc_num) {
                               case 0:
                                       page = CPM_CR_SCC1_PAGE;
                                       sblock = CPM_CR_SCC1_SBLOCK;
                                       break;
                               case 1:
                                       page = CPM_CR_SCC2_PAGE;
                                       sblock = CPM_CR_SCC2_SBLOCK;
                                       break;
                               case 2:
                                       page = CPM_CR_SCC3_PAGE;
                                       sblock = CPM_CR_SCC3_SBLOCK;
                                       break;
                               }

....

so SCC4 is unusable, here is missing code:

                               case 3:
                                       page = CPM_CR_SCC4_PAGE;
                                       sblock = CPM_CR_SCC4_SBLOCK;
                                       break;
                               }
#1 lore raw
Quoted 1 line · Wojciech Kromer

here is orignal uart.c

Three things....

One, this code is obsolete and isn't used any more. Two, it's not a bug, just a feature enhancement. Three, if you want us to actually do something about this I need a real patch against an up to date public source tree and indication it was actually tested on some platform.

Thanks.

	-- Dan
#2 lore raw
Quoted 6 lines

Three things....

One, this code is obsolete and isn't used any more.

It's in latest linuxppc_2_4_devel from denx.de CVS.

Quoted 3 lines

Two, it's not a bug, just a feature enhancement.

OK.

Quoted 6 lines

Three, if you want us to actually do something about this I need a real patch against an up to date public source tree and indication it was actually tested on some platform.

I'm currently using CVS version from denx.de,
there are lot of features I'm using.

Just use this info as an information, not offcial bug note. I spend few days finding it.