gitview: Use monospace font to draw the branch and tag name
This patch address the below:
Use monospace font to draw branch and tag name
set the font size to 13.
Make the graph column resizable. This helps to accommodate large tag names
---
contrib/gitview/gitview | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-)
725c7d29cbe4efd0a7f7d9f218dc12e36f5920de
contrib/gitview/gitview +6 -4
@@ -174,9 +174,9 @@ class CellRendererGraph(gtk.GenericCellR names_len = 0 if (len(names) != 0): for item in names: - names_len += len(item)/3 + names_len += len(item) - width = box_size * (cols + 1 + names_len ) + width = box_size * (cols + 1 ) + names_len height = box_size # FIXME I have no idea how to use cell_area properly
@@ -258,6 +258,8 @@ class CellRendererGraph(gtk.GenericCellR for item in names: name = name + item + " " + ctx.select_font_face("Monospace") + ctx.set_font_size(13) ctx.text_path(name) self.set_colour(ctx, colour, 0.0, 0.5)
@@ -537,8 +539,8 @@ class GitView: cell = CellRendererGraph() column = gtk.TreeViewColumn() - column.set_resizable(False) - column.pack_start(cell, expand=False) + column.set_resizable(True) + column.pack_start(cell, expand=True) column.add_attribute(cell, "node", 1) column.add_attribute(cell, "in-lines", 2) column.add_attribute(cell, "out-lines", 3)
Signature · 1 line
1.2.0-dirty
Quoted 3 lines · Aneesh Kumar K.V
This patch address the below:
Use monospace font to draw branch and tag name
set the font size to 13.
I have an impression that hardcoding UI policy like this is generally frowned upon.
Quoted 8 lines · Junio C Hamano
Quoted 3 lines · Aneesh Kumar K.V
This patch address the below:
Use monospace font to draw branch and tag name
set the font size to 13.I have an impression that hardcoding UI policy like this is generally frowned upon.
But with that changes branch and the tag name looks neat.
May be down the line we can add a prefernce tag that will allow the user to change all these hardcoded values.
-aneesh
Quoted 11 lines · Aneesh Kumar
Quoted 8 lines · Junio C Hamano
Quoted 3 lines · Aneesh Kumar K.V
This patch address the below:
Use monospace font to draw branch and tag name
set the font size to 13.I have an impression that hardcoding UI policy like this is generally frowned upon.
But with that changes branch and the tag name looks neat.
The point being that it only looks neat on your display, with its size and resolution, and to your eye.
People have different tastes and equipments. One thing I really liked gitk (I do not know if gitview does this as well -- if so I am happy) is I can do - and + to change the text size depending on what display I am working on.
Quoted 6 lines · Junio C Hamano
Quoted 5 lines
Quoted 3 lines
I have an impression that hardcoding UI policy like this is generally frowned upon.
But with that changes branch and the tag name looks neat.
Quoted 9 lines
The point being that it only looks neat on your display, with its size and resolution, and to your eye.
People have different tastes and equipments. One thing I really liked gitk (I do not know if gitview does this as well -- if so I am happy) is I can do - and + to change the text size depending on what display I am working on.
Point taken. Right now gitview doesn't support + and - key binding. I will try to add that. For the time being can you can drop my font and font size related changes and apply rest of the patches.
-aneesh