Skip to contentSkip to conversation

move PP_MAJOR from ppdev.h to major.h

TRIVIAL Rene Herman 1 participant 1 message Feb 26, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi Andrew.

Is this okay? Today I wondered about /dev/parport<n> after not seeing anything in drivers/parport register char-major-99. Having PP_MAJOR in include/linux/major.h would've allowed me to more quickly determine that it was the ppdev driver driving these.

Rene

drivers/char/ppdev.c +2 -1
Index: local/drivers/char/ppdev.c
===================================================================
@@ -65,10 +65,11 @@
 #include <linux/parport.h>
 #include <linux/ctype.h>
 #include <linux/poll.h>
-#include <asm/uaccess.h>
+#include <linux/major.h>
 #include <linux/ppdev.h>
 #include <linux/smp_lock.h>
 #include <linux/device.h>
+#include <asm/uaccess.h>
 
 #define PP_VERSION "ppdev: user-space parallel port driver"
 #define CHRDEV "ppdev"
include/linux/major.h +1 -0
Index: local/include/linux/major.h
===================================================================
@@ -113,6 +113,7 @@
 
 #define UBD_MAJOR		98
 
+#define PP_MAJOR		99
 #define JSFD_MAJOR		99
 
 #define PHONE_MAJOR		100
include/linux/ppdev.h +0 -2
Index: local/include/linux/ppdev.h
===================================================================
@@ -14,8 +14,6 @@
  * Added PPGETMODES/PPGETMODE/PPGETPHASE, Fred Barnes <[email protected]>, 03/01/2001
  */
 
-#define PP_MAJOR	99
-
 #define PP_IOCTL	'p'
 
 /* Set mode for read/write (e.g. IEEE1284_MODE_EPP) */