Skip to contentSkip to conversation

aic79xx: use tcq functions

PATCH New Hannes Reinecke 1 participant 1 message Mar 8, 2006

Subsystems (2)
SCSI AIC7XXX / AIC79XX SCSI driver
lore
Share & tools
lore

Hannes Reinecke

author
#0 lore raw

PATCH 2/7 aic79xx: use tcq functions

This patch converts aic79xx to use the midlayer-supplied tcq functions.

We also set the queuedepth to '1' if tcq is disabled; the aic79xx driver gets confused otherwise. Will set it back to '2' once I figure out how to queue requests in the driver.

Signed-off-by Hannes Reinecke <[email protected]>
Signature · 4 lines
Dr. Hannes Reinecke			[email protected]
SuSE Linux Products GmbH		S390 & zSeries
Maxfeldstraße 5				+49 911 74053 688
90409 Nürnberg				http://www.suse.de

[PATCH 02/07] aic79xx: use tcq functions

This patch converts aic79xx to use the midlayer-supplied tcq functions.

We also set the queuedepth to '1' if tcq is disabled; the aic79xx driver gets confused otherwise. Will set it back to '2' once I figure out how to queue requests in the driver.

Signed-off-by Hannes Reinecke <[email protected]>

---

 drivers/scsi/aic7xxx/aic79xx_osm.c |   14 +++++---------
 1 files changed, 5 insertions(+), 9 deletions(-)

2cb1ba5e7ad88ae1353f9d0804bdb46244050962

drivers/scsi/aic7xxx/aic79xx_osm.c +5 -9
index bd2be6a..be40681 100644
@@ -1342,14 +1342,12 @@ ahd_platform_set_tags(struct ahd_softc *
 
 	switch ((dev->flags & (AHD_DEV_Q_BASIC|AHD_DEV_Q_TAGGED))) {
 	case AHD_DEV_Q_BASIC:
-		scsi_adjust_queue_depth(sdev,
-					MSG_SIMPLE_TASK,
-					dev->openings + dev->active);
+		scsi_set_tag_type(sdev, MSG_SIMPLE_TASK);
+		scsi_activate_tcq(sdev, dev->openings + dev->active);
 		break;
 	case AHD_DEV_Q_TAGGED:
-		scsi_adjust_queue_depth(sdev,
-					MSG_ORDERED_TASK,
-					dev->openings + dev->active);
+		scsi_set_tag_type(sdev, MSG_ORDERED_TASK);
+		scsi_activate_tcq(sdev, dev->openings + dev->active);
 		break;
 	default:
 		/*

@@ -1358,9 +1356,7 @@ ahd_platform_set_tags(struct ahd_softc *
 		 * serially on the controller/device.  This should
 		 * remove some latency.
 		 */
-		scsi_adjust_queue_depth(sdev,
-					/*NON-TAGGED*/0,
-					/*queue depth*/2);
+		scsi_deactivate_tcq(sdev, 1);
 		break;
 	}
 }
Signature · 1 line
1.1.3