Skip to contentSkip to conversation

arcfb: Fix dereference before NULL check

PATCH In review Antonino A. Daplas 1 participant 1 message Mar 11, 2006 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 6/18 arcfb: Fix dereference before NULL check

info->par is dereferenced before info is checked for NULL. Fix.

Coverity Bug 833

---

 drivers/video/arcfb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/video/arcfb.c +1 -1
index 0cf26da..4660428 100644
@@ -459,11 +459,11 @@ static ssize_t arcfb_write(struct file *
 	inode = file->f_dentry->d_inode;
 	fbidx = iminor(inode);
 	info = registered_fb[fbidx];
-	par = info->par;
 
 	if (!info || !info->screen_base)
 		return -ENODEV;
 
+	par = info->par;
 	xres = info->var.xres;
 	fbmemlength = (xres * info->var.yres)/8;
 

-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642