Au1xx0: OHCI region size off-by-one
PATCH 1/1 Au1xx0: OHCI region size off-by-one
Hello.
Reposting with signoff which I constantly forget about... :-/
Au1xx0 OHCI driver claims one byte too many for the memory mapped
controller registers.
WBR, Sergei
arch/mips/au1000/common/platform.c +1 -1
@@ -20,7 +20,7 @@static struct resource au1xxx_usb_ohci_resources[] = { [0 ] = { .start =USB_OHCI_BASE , - .end =USB_OHCI_BASE +USB_OHCI_LEN , + .end =USB_OHCI_BASE +USB_OHCI_LEN -1 , .flags =IORESOURCE_MEM , }, [1 ] = {
Quoted 1 line · Sergei Shtylylov
Reposting with signoff which I constantly forget about... :-/
... and please post your patches inline rather than as MIME attachments. :)
Signature · 2 lines
Martin Michlmayr http://www.cyrius.com/
Quoted 7 lines · Martin Michlmayr
Quoted 1 line · Sergei Shtylylov
Reposting with signoff which I constantly forget about... :-/
... and please post your patches inline rather than as MIME attachments. :)
My mailer will stuff tabs with spaces then, and I know text/plain
attachments are considered OK.
WBR, Sergei
Quoted 5 lines · Sergei Shtylylov
Quoted 2 lines
... and please post your patches inline rather than as MIME attachments. :)
My mailer will stuff tabs with spaces then, and I know text/plain
attachments are considered OK.
Well, the topic isn't new but here is some wisdom from others on how to post patches with the various wannabe mail clients like Mozilla.
Quoting from Alan Cox:
Quoted 7 lines
For Evolution
Set the formatting to "Preformat"
Hit Insert/Text File (Alt-I X)
Then at the ghastly gnome dialog hit ^L (secret handshake for the
'developers cant stand it either' shortcut box) and type in the file name
And here some wisedom from Randy Dunlap on Thunderbird:
Quoted 10 lines
Quoted 5 lines
Randy D. eventually agreed that there was a way, IIRC:
http://lkml.org/lkml/2005/12/27/191
Probably can work your way through the thread to figure out how (I use mutt :)
Yep, the odd part is not to disable html email.
Then when composing a message, there is a drop-down box for a format selection. While the cursor is in the body area, change the format from default "Body text" to Preformat, and then copy-n-paste the patch. At least that's what worked for me.
And Frank Sorenson:
Quoted 12 lines
Here is one method for posting patches in Thunderbird:
Before starting to write the email, do
Edit->Preferences, Composition tab, change "Wrap plain text messages at __ characters" to 0Begin writing your email
Start up an editor in which you can select the text, for example:
# gvim patch.diff Edit->Select All Edit->Copy
Quoted 5 lines
Switch back to the open Compose window, then
Edit->PasteIf you have Enigmail configured, when sending the email, you might get a box asking if you want to change the line wrapping to 68 characters, so just say No if that happens.
Others have suggested using an external editor which will show up in the compose editor and allow to include the patch file inline.
Here's Martin Bligh's page on the topic:
http://mbligh.org/linuxdocs/Email/Clients/Thunderbird
Credits for anybody would writes some useful docs for the linux-mips wiki on this topic - unfortunately it's really high in demand. I'd do it myself - but I am a mutt + vi user :-)
Ralf
Quoted 12 lines · Hello, I wrote:
Au1xx0 OHCI driver claims one byte too many for the memory mapped
controller registers.Signed-off-by Sergei Shtylyov <[email protected]>------------------------------------------------------------------------
arch/mips/au1000/common/platform.c +0
-0
arch/mips/au1000/common/platform.c line 26
Quoted 8 lines
arch/mips/au1000/common/platform.c +1
-1@@ -20,7 +20,7 @@static struct resource au1xxx_usb_ohci_resources[] = { [0 ] = { .start =USB_OHCI_BASE , - .end =USB_OHCI_BASE +USB_OHCI_LEN , + .end =USB_OHCI_BASE +USB_OHCI_LEN -1 , .flags =IORESOURCE_MEM , }, [1 ] = {
There's no need to apply this anymore -- was covered by Au1200 OCHI patch...
WBR, Sergei