AMD Au1x00: AC'97 controller is memory mapped
PATCH 1/1 AMD Au1x00: AC'97 controller is memory mapped
Hello.
Reposting with signoff which I constantly forget about... :-/
AMD Au1x00 ALSA driver erroneously calls request_region() for AC'97
controller registers -- the controller is actually memory mapped at addresses 0x10000000 thru 0x100FFFFF.
WBR, Sergei
sound/mips/au1x00.c +4 -3
@@ -561,12 +561,13 @@ snd_au1000_ac97_new(struct snd_au1000 *a .read = snd_au1000_ac97_read, }; -if ((au1000->ac97_res_port =request_region (AC97C_CONFIG , -sizeof (struct au1000_ac97_reg ),"Au1x00 AC97" )) ==NULL ) { +if ((au1000->ac97_res_port =request_mem_region (CPHYSADDR (AC97C_CONFIG ), +0x100000 ,"Au1x00 AC97" )) ==NULL ) {snd_printk (KERN_ERR "ALSA AC97: can't grap AC97 port\n" );return -EBUSY ; } - au1000->ac97_ioport = (struct au1000_ac97_reg *) au1000->ac97_res_port->start; + au1000->ac97_ioport = (struct au1000_ac97_reg *) +KSEG1ADDR (au1000->ac97_res_port->start);spin_lock_init (&au1000->ac97_lock);
Takashi Iwai
AppliedAt Tue, 21 Mar 2006 04:01:01 +0300,
Quoted 5 lines · Sergei Shtylylov
Hello.
Reposting with signoff which I constantly forget about... :-/
Quoted 7 lines
AMD Au1x00 ALSA driver erroneously calls
request_region()for AC'97
controller registers -- the controller is actually memory mapped at addresses0x10000000thru0x100FFFFF.WBR, Sergei
Signed-off-by Sergei Shtylyov <[email protected]>
Thanks, applied both patches now (with signed-off :)
Takashi
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642