mm: An enhancement of OVERCOMMIT_GUESS

PATCH In review Hideo AOKI 1 participant 1 message Apr 5, 2006

Subsystems (2)

Memory management Memory mapping

lore

Share & tools

lore

Hideo AOKI

author

2006-04-05 23:48 UTC #0 lore raw

PATCH 2/3 mm: An enhancement of OVERCOMMIT_GUESS

This patch is the main part of this enhancement.
Additionally, the patch includes better error handling in __vm_enough_memory().

---
Hideo Aoki, Hitachi Computer Products (America) Inc.

This patch is an enhancement of OVERCOMMIT_GUESS algorithm in __vm_enough_memory() in mm/mmap.c.

When the OVERCOMMIT_GUESS algorithm calculates the number of free pages, the algorithm subtracts the number of reserved pages from the result nr_free_pages().

Signed-off-by Hideo Aoki <[email protected]>

---

 mmap.c |   18 +++++++++++++++---
 1 files changed, 15 insertions(+), 3 deletions(-)

mm/mmap.c +15 -3

diff -purN linux-2.6.17-rc1-mm1/mm/mmap.c linux-2.6.17-rc1-mm1-idea6/mm/mmap.c
@@ -121,14 +121,26 @@ int __vm_enough_memory(long pages, int c
 		 * only call if we're about to fail.
 		 */
 		n = nr_free_pages();
+
+		/*
+		 * Leave reserved pages. The pages are not for anonymous pages.
+		 */
+		if (n <= totalreserve_pages)
+			goto error;
+		else
+			n -= totalreserve_pages;
+
+		/*
+		 * Leave the last 3% for root
+		 */
 		if (!cap_sys_admin)
 			n -= n / 32;
 		free += n;
 
 		if (free > pages)
 			return 0;
-		vm_unacct_memory(pages);
-		return -ENOMEM;
+
+		goto error;
 	}
 
 	allowed = (totalram_pages - hugetlb_total_pages())

@@ -150,7 +162,7 @@ int __vm_enough_memory(long pages, int c
 	 */
 	if (atomic_read(&vm_committed_space) < (long)allowed)
 		return 0;
-
+error:
 	vm_unacct_memory(pages);
 
 	return -ENOMEM;