let skins select nucleus features
PATCH 1/1 let skins select nucleus features
Hi,
this patch aims at avoiding to select unneeded nucleus features if no user is requiring it in the skins. Particularly, it addresses the nucleus registry and the pipes.
I have spent no effort on 2.4 yet as I first want to wait for comments. Furthermore, 2.4. is lacking "select", so the feature selection has to remain manually there anyway.
Jan
nucleus/Kconfig +12 -17
@@ -32,15 +32,7 @@ config XENO_OPT_SECURITY_ACCESS think twice before switching this off. config XENO_OPT_PIPE - bool "Message pipes" - default y - help - - Message pipes are bi-directional FIFO communication - channels allowing data exchange between real-time kernel - threads and regular user-space processes. Pipes natively - preserve message boundaries, but can also be used in byte - streaming mode from kernel to user-space. + bool config XENO_OPT_PIPE_NRDEV int "Number of pipe devices"
@@ -48,14 +40,23 @@ config XENO_OPT_PIPE_NRDEV default 32 help + Message pipes are bi-directional FIFO communication + channels allowing data exchange between real-time kernel + threads and regular user-space processes. Pipes natively + preserve message boundaries, but can also be used in byte + streaming mode from kernel to user-space. + This option sets the maximum number of pipe devices supported in the system. Pipe devices are named /dev/rtpN where N is a device minor number ranging from 0 to XENO_OPT_PIPE_NRDEV - 1. config XENO_OPT_REGISTRY bool - prompt "Registry support" if !XENO_OPT_PERVASIVE - default y + +config XENO_OPT_REGISTRY_NRSLOTS + int "Number of registry slots" + depends on XENO_OPT_REGISTRY + default 512 help The registry is used by Xenomai skins to bind real-time
@@ -63,12 +64,6 @@ config XENO_OPT_REGISTRY can be further retrieved and shared by real-time applications regardless of their runtime space (i.e. kernel or user). Each named object occupies a registry slot. - -config XENO_OPT_REGISTRY_NRSLOTS - int "Number of registry slots" - depends on XENO_OPT_REGISTRY - default 512 - help This option sets the maximum number of real-time objects the registry can handle. All skins using the registry share this
skins/vrtx/Kconfig +1 -1
@@ -1,7 +1,7 @@ config XENO_SKIN_VRTX depends on XENO_OPT_NUCLEUS tristate "VRTX emulator" - default n + select XENO_OPT_REGISTRY help This API skin emulates Mentor Graphics's VRTX operating
skins/vxworks/Kconfig +1 -1
@@ -1,7 +1,7 @@ config XENO_SKIN_VXWORKS depends on XENO_OPT_NUCLEUS tristate "VxWorks emulator" - default n + select XENO_OPT_REGISTRY help This API skin emulates WindRiver's VxWorks operating system.
skins/native/Kconfig +13 -1
@@ -10,7 +10,7 @@ if XENO_SKIN_NATIVE != n config XENO_OPT_NATIVE_PIPE bool "Message pipes" - depends on XENO_OPT_PIPE + select XENO_OPT_PIPE default y help
@@ -33,6 +33,18 @@ config XENO_OPT_NATIVE_PIPE_BUFSZ This option sets the memory size available for per-pipe buffering when message pipes are used in byte stream mode. +config XENO_OPT_NATIVE_REGISTRY + bool + prompt "Registry support" if !XENO_OPT_PERVASIVE + select XENO_OPT_REGISTRY + default y + help + + The registry is used to bind real-time objects to symbolic names, + so that these objects can be further retrieved and shared by + real-time applications regardless of their runtime space (i.e. + kernel or user). Each named object occupies a registry slot. + config XENO_OPT_NATIVE_SEM bool "Counting semaphores" default y
Quoted 9 lines · Jan Kiszka
Hi,
this patch aims at avoiding to select unneeded nucleus features if no user is requiring it in the skins. Particularly, it addresses the nucleus registry and the pipes.
I have spent no effort on 2.4 yet as I first want to wait for comments. Furthermore, 2.4. is lacking "select", so the feature selection has to remain manually there anyway.
Looks good. Merged, thanks.
Signature · 1 line
Philippe.
Quoted 7 lines · Philippe Gerum
Quoted 6 lines · Jan Kiszka
Hi,
this patch aims at avoiding to select unneeded nucleus features if no user is requiring it in the skins. Particularly, it addresses the nucleus registry and the pipes.
Quoted 6 lines
Quoted 3 lines
I have spent no effort on 2.4 yet as I first want to wait for comments. Furthermore, 2.4. is lacking "select", so the feature selection has to remain manually there anyway.
Looks good. Merged, thanks.
In the same sense, but not that comfortable, here is the a 2.4 variant of the patch.
Jan
skins/vrtx/Config.in +6 -0
@@ -2,4 +2,10 @@ # Xenomai configuration for Linux v2.4 # +if [ "$CONFIG_XENO_OPT_REGISTRY" = "n" ]; then + comment 'VRTX emulator requires CONFIG_XENO_OPT_REGISTRY' +else + dep_tristate 'VRTX emulator' CONFIG_XENO_SKIN_VRTX $CONFIG_XENO_OPT_NUCLEUS + +fi
skins/vxworks/Config.in +6 -0
@@ -2,4 +2,10 @@ # Xenomai configuration for Linux v2.4 # +if [ "$CONFIG_XENO_OPT_REGISTRY" = "n" ]; then + comment 'VxWorks emulator requires CONFIG_XENO_OPT_REGISTRY' +else + dep_tristate 'VxWorks emulator' CONFIG_XENO_SKIN_VXWORKS $CONFIG_XENO_OPT_NUCLEUS + +fi
skins/native/Config.in +6 -0
@@ -2,6 +2,10 @@ # Xenomai configuration for Linux v2.4 # +if [ "$CONFIG_XENO_OPT_PERVASIVE" = "y" -a "$CONFIG_XENO_OPT_REGISTRY" = "n" ]; then + comment 'Native skin requires CONFIG_XENO_OPT_REGISTRY in pervasive mode' +else + dep_tristate 'Native skin' CONFIG_XENO_SKIN_NATIVE $CONFIG_XENO_OPT_NUCLEUS if [ "$CONFIG_XENO_SKIN_NATIVE" != "n" ]; then
@@ -24,3 +28,5 @@ if [ "$CONFIG_XENO_SKIN_NATIVE" != "n" ] bool 'Interrupts' CONFIG_XENO_OPT_NATIVE_INTR endmenu fi + +fi
nucleus/Config.in +1 -5
@@ -17,11 +17,7 @@ if [ "$CONFIG_XENO_OPT_NUCLEUS" != "n" ] if [ "$CONFIG_XENO_OPT_PIPE" != "n" ]; then int 'Number of pipe devices' CONFIG_XENO_OPT_PIPE_NRDEV 32 fi - if [ "$CONFIG_XENO_OPT_PERVASIVE" != "n" ]; then - define_bool CONFIG_XENO_OPT_REGISTRY y - else - bool 'Registry support' CONFIG_XENO_OPT_REGISTRY - fi + bool 'Registry support' CONFIG_XENO_OPT_REGISTRY if [ "$CONFIG_XENO_OPT_REGISTRY" != "n" ]; then int 'Number of registry slots' CONFIG_XENO_OPT_REGISTRY_NRSLOTS 512 fi
Quoted 14 lines · Jan Kiszka
Quoted 12 lines · Philippe Gerum
Quoted 9 lines · Jan Kiszka
Hi,
this patch aims at avoiding to select unneeded nucleus features if no user is requiring it in the skins. Particularly, it addresses the nucleus registry and the pipes.
I have spent no effort on 2.4 yet as I first want to wait for comments. Furthermore, 2.4. is lacking "select", so the feature selection has to remain manually there anyway.
Quoted 6 lines
Quoted 2 lines
Looks good. Merged, thanks.
In the same sense, but not that comfortable, here is the a 2.4 variant of the patch.
I don't agree with the logic of this patch. All user-space enabled skins may also run in pure kernel-space in non pervasive mode. A core dependency exists from CONFIG_XENO_OPT_REGISTRY on CONFIG_XENO_OPT_PERVASIVE, and it should be defined explicitely. In any case, maybe it's not worth trying to be too smart with the 2.4 configuration system when it comes to dealing with features inter-dependencies, since we really miss the proper support to do that.
Signature · 1 line
Philippe.
Quoted 22 lines · Philippe Gerum
Quoted 14 lines · Jan Kiszka
Quoted 12 lines · Philippe Gerum
Quoted 9 lines · Jan Kiszka
Hi,
this patch aims at avoiding to select unneeded nucleus features if no user is requiring it in the skins. Particularly, it addresses the nucleus registry and the pipes.
I have spent no effort on 2.4 yet as I first want to wait for comments. Furthermore, 2.4. is lacking "select", so the feature selection has to remain manually there anyway.
Quoted 6 lines
Quoted 2 lines
Looks good. Merged, thanks.
In the same sense, but not that comfortable, here is the a 2.4 variant of the patch.
Quoted 8 lines
I don't agree with the logic of this patch. All user-space enabled skins may also run in pure kernel-space in non pervasive mode. A core dependency exists from
CONFIG_XENO_OPT_REGISTRYonCONFIG_XENO_OPT_PERVASIVE, and it should be defined explicitely. In any case, maybe it's not worth trying to be too smart with the 2.4 configuration system when it comes to dealing with features inter-dependencies, since we really miss the proper support to do that.
Sorry, doesn't parse for me yet. You that when CONFIG_XENO_OPT_PERVASIVE is enabled CONFIG_XENO_OPT_REGISTRY is required (which was not correct, see POSIX skin)?
Jan
Quoted 37 lines · Jan Kiszka
Quoted 25 lines · Philippe Gerum
Quoted 16 lines · Jan Kiszka
Quoted 13 lines · Philippe Gerum
Quoted 9 lines · Jan Kiszka
Hi,
this patch aims at avoiding to select unneeded nucleus features if no user is requiring it in the skins. Particularly, it addresses the nucleus registry and the pipes.
I have spent no effort on 2.4 yet as I first want to wait for comments. Furthermore, 2.4. is lacking "select", so the feature selection has to remain manually there anyway.
Quoted 6 lines
Quoted 2 lines
Looks good. Merged, thanks.
In the same sense, but not that comfortable, here is the a 2.4 variant of the patch.
Quoted 8 lines
I don't agree with the logic of this patch. All user-space enabled skins may also run in pure kernel-space in non pervasive mode. A core dependency exists from
CONFIG_XENO_OPT_REGISTRYonCONFIG_XENO_OPT_PERVASIVE, and it should be defined explicitely. In any case, maybe it's not worth trying to be too smart with the 2.4 configuration system when it comes to dealing with features inter-dependencies, since we really miss the proper support to do that.
Quoted 3 lines
Sorry, doesn't parse for me yet. You that when
CONFIG_XENO_OPT_PERVASIVEis enabledCONFIG_XENO_OPT_REGISTRYis required (which was not correct, see POSIX skin)?
The POSIX skin is an exception, since it implemented its own registry support before the native registry was moved as a generic nucleus feature; at some point in time, the POSIX registry should be rebased on the nucleus support. We must now consider that having CONFIG_XENO_OPT_PERVASIVE set requires CONFIG_XENO_OPT_REGISTRY to be set too. OTOH, you can have CONFIG_XENO_OPT_REGISTRY set without CONFIG_XENO_OPT_PERVASIVE, if you want to run skins in kernel space only, whilst still providing registry support for inter-modules requests.
Signature · 1 line
Philippe.