Skip to contentSkip to conversation

IPC: access to unmapped vmalloc area in grow_ary()

PATCH New Kirill Korotaev 1 participant 1 message Apr 17, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 IPC: access to unmapped vmalloc area in grow_ary()

grow_ary() should not copy struct ipc_id_ary (it copies new->p, not new). Due to this, memcpy() src pointer could hit unmapped vmalloc page when near page boundary.

Found during OpenVZ stress testing

ipc/util.c renamed from git/linux-2.6.16-workgpl/ipc/util.c +1 -2
diff -urp ../git/linux-2.6.16-workgpl/ipc/util.c linux-2.6.16/ipc/util.c
@@ -187,8 +187,7 @@ static int grow_ary(struct ipc_ids* ids,
 	if(new == NULL)
 		return size;
 	new->size = newsize;
-	memcpy(new->p, ids->entries->p, sizeof(struct kern_ipc_perm *)*size +
-					sizeof(struct ipc_id_ary));
+	memcpy(new->p, ids->entries->p, sizeof(struct kern_ipc_perm *)*size);
 	for(i=size;i<newsize;i++) {
 		new->p[i] = NULL;
 	}