Skip to contentSkip to conversation

a small code review (2414483) Automated g4 rollback of changelist 2396062.

kernel-reviewers Martin Bligh 3 participants 3 messages Apr 26, 2006 11 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#11 lore raw
Quoted 15 lines · Tim Hockin
Quoted 8 lines · Ken Harrenstien

That doesn't work because IIRC it only reports the amount of memory the kernel has been told (eg via "mem=") to manage in a certain sense, not how much is actually physically available.

The I2 netboot kernel would really REALLY like some exported /proc values that accurately report physical memory (if nothing else, the number of DIMMs and their sizes). It has to figure this out in order to install the proper kernel with proper LILO command-line args.

The kernel can't really know how much memory is in the system without getting chipset-specific.

Quoted 6 lines

MTRR is a good way to hazard a guess, and will probably be right, but as you indicated, BIOS vendors have historically been REALLY bad about MTRRs. Better now, but bad a few years ago.

SMBIOS (on our boards) *does* accurately report the number of DIMMS and their sizes (and more!). But it only works on Google BIOS.

cc: linux-kernel
bcc: kernel-reviewers

Are you saying our e820 maps and srat tables are wrong? that's a little worrying ...

M.

#12 lore raw
Quoted 20 lines · Martin Bligh
Quoted 19 lines · Tim Hockin
Quoted 8 lines · Ken Harrenstien

That doesn't work because IIRC it only reports the amount of memory the kernel has been told (eg via "mem=") to manage in a certain sense, not how much is actually physically available.

The I2 netboot kernel would really REALLY like some exported /proc values that accurately report physical memory (if nothing else, the number of DIMMs and their sizes). It has to figure this out in order to install the proper kernel with proper LILO command-line args.

The kernel can't really know how much memory is in the system without getting chipset-specific.

MTRR is a good way to hazard a guess, and will probably be right, but as you indicated, BIOS vendors have historically been REALLY bad about MTRRs. Better now, but bad a few years ago.

Quoted 5 lines
Quoted 2 lines

SMBIOS (on our boards) *does* accurately report the number of DIMMS and their sizes (and more!). But it only works on Google BIOS.

Are you saying our e820 maps and srat tables are wrong? that's a little worrying ...

e820 is fine, except there's not a good kernel interface to it. Parsing dmesg is *always* a last resort.

We don;t currently have SRAT. :)

#13 lore raw
In reply to Martin Bligh
Quoted 11 lines · Martin Bligh
Quoted 10 lines · Tim Hockin
Quoted 8 lines · Ken Harrenstien

That doesn't work because IIRC it only reports the amount of memory the kernel has been told (eg via "mem=") to manage in a certain sense, not how much is actually physically available.

The I2 netboot kernel would really REALLY like some exported /proc values that accurately report physical memory (if nothing else, the number of DIMMs and their sizes). It has to figure this out in order to install the proper kernel with proper LILO command-line args.

Quoted 9 lines
Quoted 9 lines

The kernel can't really know how much memory is in the system without getting chipset-specific.
MTRR is a good way to hazard a guess, and will probably be right, but as
you indicated, BIOS vendors have historically been REALLY bad about MTRRs. Better now, but bad a few years ago.
SMBIOS (on our boards) *does* accurately report the number of DIMMS and
their sizes (and more!). But it only works on Google BIOS.

Actually quite a lot of SMBIOS report DIMMs more or less correct. It works even on my laptop.

I implemented support for it in the latest mcelog (--dmi). Not all and a few big names screw it up (in particular the mappings from address range to interleave set). But overall it looks surprisingly good so far.

-Andi