Skip to contentSkip to conversation

nfsstat for NFSv4

DISCUSSION Shankar Anand 2 participants 4 messages May 8, 2006 – May 10, 2006 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#2 lore raw
In reply to a message not in the archive

Hi,

I have added some code for NFSv4 server statistics for individual NFSv4 operations. I will submitting that to the NFS community soon.

I have some questions:
1. I noticed in Allen's patch for nfsstat for NFSv4 statistics that he has taken into account only 32 NFSv4 operations. Do you have any reasons for leaving out the other operations (like PUTFH, SECINFO, SAVEFH)?

2. I understand that in NFSv3 server we write the statistics into /proc/net/rpc/nfsd in the same order as the RPC procedure numbers. Using the same logic, I have written the NFSv4 statistics to be logged into /proc/net/rpc/nfsd in the same order in which the operations are listed in the NFSv4 RFC. But the NFSv4 client statistics that are getting printed in Allen's patch seem to be of a different order. Why was this decided to be so?

Thanks,
Shankar

#3 lore raw
Quoted 7 lines · Shankar Anand

I have added some code for NFSv4 server statistics for individual NFSv4 operations. I will submitting that to the NFS community soon.

I have some questions:
1. I noticed in Allen's patch for nfsstat for NFSv4 statistics that he has taken into account only 32 NFSv4 operations. Do you have any reasons for leaving out the other operations (like PUTFH, SECINFO, SAVEFH)?

At a guess: PUTFH and SAVEFH aren't particularly interesting, and SECINFO isn't implemented yet on the server (and isn't used yet on the client).

--b.

#4 lore raw

Hi,

Quoted 3 lines

"J. Bruce Fields" <[email protected]> 5/9/2006 3:55:31 am >>>

Quoted 2 lines · Shankar Anand

I have added some code for NFSv4 server statistics for individual

NFSv4

Quoted 4 lines
Quoted 4 lines

operations. I will submitting that to the NFS community soon.

I have some questions:
1. I noticed in Allen's patch for nfsstat for NFSv4 statistics that

he

Quoted 1 line
Quoted 1 line

has taken into account only 32 NFSv4 operations. Do you have any

reasons

Quoted 5 lines
Quoted 1 line

for leaving out the other operations (like PUTFH, SECINFO, SAVEFH)?

At a guess: PUTFH and SAVEFH aren't particularly interesting, and SECINFO isn't implemented yet on the server (and isn't used yet on

the

Quoted 1 line

client).

But the problem with this is that we skip operations in between, which breaks the order of the operations given in the RFC i.e. the linear order
in which the statistics are captured in the NFSv4 server. Just want to know why this was done when capturing the count for an extra
procedure does not require much extra effort, going by the existing code and
actually causes a break in the list of operation numbers.

Quoted 2 lines
Quoted 2 lines

2. I understand that in NFSv3 server we write the statistics into /proc/net/rpc/nfsd in the same order as the RPC procedure numbers.

Using

Quoted 1 line
Quoted 1 line

the same logic, I have written the NFSv4 statistics to be logged

into

Quoted 1 line
Quoted 1 line

/proc/net/rpc/nfsd in the same order in which the operations are

listed

Quoted 2 lines
Quoted 2 lines

in the NFSv4 RFC. But the NFSv4 client statistics that are getting printed in Allen's patch seem to be of a different order. Why was

this

Quoted 1 line
Quoted 1 line

decided to be so?

It would be great if someone can answer this too.

Regards,
Shankar

#5 lore raw

*Sorry I am repeating my previous email as it was badly cluttered*

Hi,

Quoted 12 lines

"J. Bruce Fields" <[email protected]> 5/9/2006 3:55:31 am >>>

Quoted 10 lines · Shankar Anand

I have added some code for NFSv4 server statistics for individual NFSv4 operations. I will submitting that to the NFS community soon.

I have some questions:
1. I noticed in Allen's patch for nfsstat for NFSv4 statistics that he has taken into account only 32 NFSv4 operations. Do you have any reasons for leaving out the other operations (like PUTFH, SECINFO, SAVEFH)?

Quoted 3 lines

At a guess: PUTFH and SAVEFH aren't particularly interesting, and SECINFO isn't implemented yet on the server (and isn't used yet on the client).

But the problem with this is that we skip operations in between, which breaks the order of the operations given in the RFC i.e. the linear order in which the statistics are captured in the NFSv4 server.

Just want to know why this was done when capturing the count for an extra procedure does not require much extra effort, going by the existing code and actually causes a break in the list of operation numbers.

Quoted 9 lines
Quoted 9 lines

2. I understand that in NFSv3 server we write the statistics into /proc/net/rpc/nfsd in the same order as the RPC procedure numbers. Using the same logic, I have written the NFSv4 statistics to be logged into /proc/net/rpc/nfsd in the same order in which the operations are listed in the NFSv4 RFC.
But the NFSv4 client statistics that are getting printed in Allen's patch seem to be of a different order.
Why was this decided to be so?

It would be great if someone can answer this too.

Regards,
Shankar