pci_resource_end problem revisited
Ben,
I still have this problem of OF reporting the serial port bar size as 16 instead of 8 on my G5. Where would be a proper place to fix this? BTW, I verified that it is OF that reports the size as 16.
-Geoff
-------- Original Message --------
Subject: Re: pci_resource_end() changed problem with 2.6.14
Date: Fri, 04 Nov 2005 10:36:58 -0800
From: Geoff Levand <[email protected]>
To: Benjamin Herrenschmidt <[email protected]>
CC: [email protected]
References: <[email protected]> <1131087370.4680.238.camel@gaston>
Quoted 8 lines · Benjamin Herrenschmidt
Quoted 6 lines · Geoff Levand
I found that the serial port probe code in
drivers/serial/8250_pci.cno longer works properly for ppc64 in 2.6.14. It seems the value returned bypci_resource_len()on ppc64 changed from 8 to 16 since 2.6.13. I tested on a PC andpci_resource_len()returns 8 as expected.
Quoted 9 lines
Interesting... What does an lspci -vv shows for the BARs of the PCI card ? Also, what do you have in
/proc/device-tree? What is the machine precisely ?2.6.14 now uses the OF device-tree to generate the linux PCI tree instead of going directly to PCI probing. It's possible that this is causing your problem if for some reason, the BAR sizing done by OF ends up being different than what the kernel does ...
Sorry, I should have mentioned it, this is on my PowerMac G5 with a generic 8250 serial PCI card (StarTech PCI4S550N). Here's what lspci gives me:
0001:05:03.0 Serial controller: NetMos Technology PCI 9845 Multi-I/O Controller (rev 01) (prog-if 02 [16550])
Subsystem: LSI Logic / Symbios Logic 0P4S (4 port 16550A serial card)
Control: I/O+ Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
Status: Cap- 66Mhz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Interrupt: pin A routed to IRQ 53
Region 0: I/O ports at f4000050 [size=16]
Region 1: I/O ports at f4000040 [size=16]
Region 2: I/O ports at f4000030 [size=16]
Region 3: I/O ports at f4000020 [size=16]
Region 4: I/O ports at f4000010 [size=16]
Region 5: I/O ports at f4000000 [size=16]It could be the change to using the OF device-tree. What's an easy way to see the size OF has used?
-Geoff
Quoted 4 lines
I still have this problem of OF reporting the serial port bar size as 16 instead of 8 on my G5. Where would be a proper place to fix this? BTW, I verified that it is OF that reports the size as 16.
Make fixup_device_tree() fix the dev tree itself?
Quoted 6 lines
0001:05:03.0 Serial controller: NetMos Technology PCI 9845 Multi-I/O Controller (rev 01) (prog-if 02 [16550])
Subsystem: LSI Logic / Symbios Logic 0P4S (4 port 16550A
serial card)
Control: I/O+ Mem- BusMaster- SpecCycle- MemWINV- VGASnoop-
ParErr- Stepping- SERR- FastB2B-
Status: Cap- 66Mhz- UDF- FastB2B+ ParErr- DEVSEL=medium
Quoted 8 lines
Quoted 1 line
TAbort- <TAbort- <MAbort- >SERR- <PERR-
Interrupt: pin A routed to IRQ 53 Region 0: I/O ports at f4000050 [size=16] Region 1: I/O ports at f4000040 [size=16] Region 2: I/O ports at f4000030 [size=16] Region 3: I/O ports at f4000020 [size=16] Region 4: I/O ports at f4000010 [size=16] Region 5: I/O ports at f4000000 [size=16]
Also note that the last BAR is at legacy I/O address 0, various things will break due to bogus assumptions... this BAR is not needed for the UARTs though :-)
Segher