Skip to contentSkip to conversation

memstick: add support for JMicron jmb38x MemoryStick host controller

PATCH Alex Dubov 1 participant 1 message Mar 6, 2008

lore
Share & tools
lore

Alex Dubov

author
#0 lore raw
Quoted 14 lines · --- Andrew Morton

Review

Quoted 9 lines · On Wed, 5 Mar 2008 03:02:28 +1100 [email protected] wrote:
(quoted diff) +9 -0
+static void jmb38x_ms_reset(struct jmb38x_ms_host *host)
+{
+	unsigned int host_ctl = readl(host->addr + HOST_CONTROL);
+
+	writel(host_ctl | HOST_CONTROL_RESET_REQ | HOST_CONTROL_RESET,
+	       host->addr + HOST_CONTROL);
+
+	while (HOST_CONTROL_RESET_REQ
+	       & (host_ctl = readl(host->addr + HOST_CONTROL))) {

host_ctl is written to but is not used again.

It was supposed to be used in the dev_dbg printout.

Quoted 11 lines

Review

Quoted 10 lines
(quoted diff) +9 -0
+		ndelay(100);
+		dev_dbg(&host->chip->pdev->dev, "reset\n");
+	}
+
+	writel(INT_STATUS_ALL, host->addr + INT_STATUS_ENABLE);
+	writel(INT_STATUS_ALL, host->addr + INT_SIGNAL_ENABLE);
+
+	dev_dbg(&host->chip->pdev->dev, "reset\n");
+}
      ____________________________________________________________________________________

Be a better friend, newshound, and
know-it-all with Yahoo! Mobile. Try it now. http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ