nfsd: sign conversion obscuring errors in nfsd_set_posix_acl()
PATCH 1/1 nfsd: sign conversion obscuring errors in nfsd_set_posix_acl()
Assigning the result of posix_acl_to_xattr() to an unsigned data type (size/size_t) obscures possible errors.
Coverity CID: 1206.
Signed-off-by Florin Malita <[email protected]>
---
fs/nfsd/vfs.c +3 -4
@@ -1922,11 +1922,10 @@ nfsd_set_posix_acl(struct svc_fh *fhp, i value =kmalloc (size,GFP_KERNEL );if (!value)return -ENOMEM ; - size =posix_acl_to_xattr (acl, value, size); -if (size <0 ) { - error = size; + error =posix_acl_to_xattr (acl, value, size); +if (error <0 ) goto getout; - } + size = error; }else size =0 ;
Quoted 4 lines · On Monday May 15, [email protected] wrote:
Assigning the result of
posix_acl_to_xattr()to an unsigned data type (size/size_t) obscures possible errors.Coverity CID: 1206.
Acked-by NeilBrown <[email protected]>
Thanks.
This is non-critical as posix_acl_to_xattr won't actually return an error here (with current code anyway), but it is certainly worth fixing.
The fact that posix_acl_to_xattr takes a 'size_t' for size and returns a int is a bit bothersome... oh well.
NeilBrown
Quoted 24 lines
Signed-off-by Florin Malita <[email protected]>---
fs/nfsd/vfs.c +3
-4@@ -1922,11 +1922,10 @@ nfsd_set_posix_acl(struct svc_fh *fhp, i value =kmalloc (size,GFP_KERNEL );if (!value)return -ENOMEM ; - size =posix_acl_to_xattr (acl, value, size); -if (size <0 ) { - error = size; + error =posix_acl_to_xattr (acl, value, size); +if (error <0 ) goto getout; - } + size = error; }else size =0 ;