Was this really supposed to go in?
Commit 2c171bf13423dc5293188cea7f6c2da1720926e2 in Linus' tree seems strange. It includes more changes than Pavel's original patch, but with the same commit message. Also, I think the extra changes are broken as we then would have two parameters that have that contain the same information, yet the do not have the same ranges.
gitweb of the commit:
http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=2c171bf13423dc5293188cea7f6c2da1720926e2
Rgds
Pierre
Quoted 3 lines · Pierre Ossman
Commit
2c171bf13423dc5293188cea7f6c2da1720926e2in Linus' tree seems strange. It includes more changes than Pavel's original patch, but with the same commit message.
They shouldn't have gone in - they were a change I was working on a few days ago which I left in the git tree uncommitted. Applying Pavel's patch then committed them.
Quoted 3 lines
Also, I think the extra changes are broken as we then would have two parameters that have that contain the same information, yet the do not have the same ranges.
It's part of transitioning the data transfers over to taking the byte size instead of the log2 byte size.
Well, I can't do anything about it now - I'm going away for a couple of weeks from tomorrow morning.
Signature · 3 lines
Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core
Quoted 3 lines · Russell King
It's part of transitioning the data transfers over to taking the byte size instead of the log2 byte size.
As long as it's a complete move and not having both, then I'm all for it.
Quoted 4 lines
Well, I can't do anything about it now - I'm going away for a couple of weeks from tomorrow morning.
The patch doesn't really break anything as the only two users make sure the parameters are in sync, so it's no rush. Just make sure it's on your list when you get back. ;)
Rgds
Pierre