orinoco: possible null pointer dereference in orinoco_rx_monitor()
PATCH 1/1 orinoco: possible null pointer dereference in orinoco_rx_monitor()
If the skb allocation fails, the current error path calls dev_kfree_skb_irq() with a NULL argument. Also, 'err' is not being used.
Coverity CID: 275.
Signed-off-by Florin Malita <[email protected]>
---
drivers/net/wireless/orinoco.c +1 -3
@@ -812,7 +812,6 @@ static void orinoco_rx_monitor(struct neif (datalen >IEEE80211_DATA_LEN +12 ) {printk (KERN_DEBUG "%s: oversized monitor frame, " "data length = %d\n" , dev->name, datalen); - err = -EIO ; stats->rx_length_errors++; goto update_stats; }
@@ -821,8 +820,7 @@ static void orinoco_rx_monitor(struct neif (!skb) {printk (KERN_WARNING "%s: Cannot allocate skb for monitor frame\n" , dev->name); - err = -ENOMEM ; - goto drop; + goto update_stats; }/* Copy the 802.11 header to the skb */