Skip to contentSkip to conversation

: H.323 helper: fix sequence extension parsing

PATCH In review Patrick McHardy 1 participant 1 message May 23, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/3 : H.323 helper: fix sequence extension parsing

[NETFILTER]: H.323 helper: fix sequence extension parsing

When parsing unknown sequence extensions the "son"-pointer points behind the last known extension for this type, don't try to interpret it.

---
commit e79f105111e9a6088868a879934d0574ce6230ad
tree 5d61518ccb84bd58632eca399235459d9a2cd49c
parent 97326cd6bc2a1360c213113cf1c7bc5514ad6d5b
author Patrick McHardy <[email protected]> Tue, 23 May 2006 11:16:22 +0200 committer Patrick McHardy <[email protected]> Tue, 23 May 2006 11:16:22 +0200

 net/ipv4/netfilter/ip_conntrack_helper_h323_asn1.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/ipv4/netfilter/ip_conntrack_helper_h323_asn1.c +1 -1
index 5d04438..26dfeca 100644
@@ -555,7 +555,7 @@ int decode_seq(bitstr_t * bs, field_t * 
 
 	/* Decode the extension components */
 	for (opt = 0; opt < bmp2_len; opt++, i++, son++) {
-		if (son->attr & STOP) {
+		if (i < f->ub && son->attr & STOP) {
 			PRINT("%*.s%s\n", (level + 1) * TAB_SIZE, " ",
 			      son->name);
 			return H323_ERROR_STOP;