Skip to contentSkip to conversation

PCMCIA: missing pcmcia_get_socket() result check

PATCH Applied Florin Malita 2 participants 2 messages May 25, 2006 – May 30, 2006 Pcmcia

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCMCIA: missing pcmcia_get_socket() result check

The result of pcmcia_get_socket() may be NULL but ds_event() uses it without checking.

Coverity CID: 436.

---

drivers/pcmcia/ds.c +6 -0
index 48d3b3d..74b3124 100644
@@ -1143,6 +1143,12 @@ static int ds_event(struct pcmcia_socket
 {
 	struct pcmcia_socket *s = pcmcia_get_socket(skt);
 
+	if (!s) {
+		printk(KERN_ERR "PCMCIA obtaining reference to socket %p " \
+			"failed, event 0x%x lost!\n", skt, event);
+		return -ENODEV;
+	}
+
 	ds_dbg(1, "ds_event(0x%06x, %d, 0x%p)\n",
 	       event, priority, skt);
 
maintainer Applied
#1 lore raw

Hi,

Quoted 2 lines · Florin Malita

The result of pcmcia_get_socket() may be NULL but ds_event() uses it without checking.

Applied, thanks.

Dominik