Skip to contentSkip to conversation

backlight: Fix Kconfig dependency

PATCH In review Antonino A. Daplas 2 participants 3 messages May 28, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 5/5 backlight: Fix Kconfig dependency

CONFIG_FB = m and CONFIG_{BACKLIGHT:LCD}_CLASS_DEVICE = y is possible resulting in link errors. Fix by making backlight and lcd class also depend on FB

---

 drivers/video/backlight/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/video/backlight/Kconfig +2 -2
index 02f1529..022f9d3 100644
@@ -10,7 +10,7 @@ menuconfig BACKLIGHT_LCD_SUPPORT
 
 config BACKLIGHT_CLASS_DEVICE
         tristate "Lowlevel Backlight controls"
-	depends on BACKLIGHT_LCD_SUPPORT
+	depends on BACKLIGHT_LCD_SUPPORT && FB
 	default m
 	help
 	  This framework adds support for low-level control of the LCD
@@ -26,7 +26,7 @@ config BACKLIGHT_DEVICE
 
 config LCD_CLASS_DEVICE
         tristate "Lowlevel LCD controls"
-	depends on BACKLIGHT_LCD_SUPPORT
+	depends on BACKLIGHT_LCD_SUPPORT && FB
 	default m
 	help
 	  This framework adds support for low-level control of LCD.

-------------------------------------------------------
All the advantages of Linux Managed Hosting--Without the Cost and Risk! Fully trained technicians. The highest number of Red Hat certifications in the hosting industry. Fanatical Support. Click to learn more
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642

#1 lore raw
Quoted 24 lines · On Sun, 28 May 2006 08:42:07 +0800 "Antonino A. Daplas" <[email protected]>…

CONFIG_FB = m and CONFIG_{BACKLIGHT:LCD}_CLASS_DEVICE = y is possible resulting in link errors. Fix by making backlight and lcd class also depend on FB

---

 drivers/video/backlight/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/video/backlight/Kconfig +1 -1
index 02f1529..022f9d3 100644
@@ -10,7 +10,7 @@ menuconfig BACKLIGHT_LCD_SUPPORT
 
 config BACKLIGHT_CLASS_DEVICE
         tristate "Lowlevel Backlight controls"
-	depends on BACKLIGHT_LCD_SUPPORT
+	depends on BACKLIGHT_LCD_SUPPORT && FB
 	default m
 	help
 	  This framework adds support for low-level control of the LCD

drivers/video/backlight/Kconfig config BACKLIGHT_DEVICE · line 32

Quoted 8 lines
drivers/video/backlight/Kconfig +1 -1
@@ -26,7 +26,7 @@ config BACKLIGHT_DEVICE
 
 config LCD_CLASS_DEVICE
         tristate "Lowlevel LCD controls"
-	depends on BACKLIGHT_LCD_SUPPORT
+	depends on BACKLIGHT_LCD_SUPPORT && FB
 	default m
 	help
 	  This framework adds support for low-level control of LCD.

Would I be correct in believing that this is a mainline fix and hence 2.6.17 material?

-------------------------------------------------------
All the advantages of Linux Managed Hosting--Without the Cost and Risk! Fully trained technicians. The highest number of Red Hat certifications in the hosting industry. Fanatical Support. Click to learn more
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642

#2 lore raw
Quoted 28 lines · Andrew Morton
Quoted 25 lines · On Sun, 28 May 2006 08:42:07 +0800 "Antonino A. Daplas" <[email protected]>…

CONFIG_FB = m and CONFIG_{BACKLIGHT:LCD}_CLASS_DEVICE = y is possible resulting in link errors. Fix by making backlight and lcd class also depend on FB

---

 drivers/video/backlight/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/video/backlight/Kconfig +1 -1
index 02f1529..022f9d3 100644
@@ -10,7 +10,7 @@ menuconfig BACKLIGHT_LCD_SUPPORT
 
 config BACKLIGHT_CLASS_DEVICE
         tristate "Lowlevel Backlight controls"
-	depends on BACKLIGHT_LCD_SUPPORT
+	depends on BACKLIGHT_LCD_SUPPORT && FB
 	default m
 	help
 	  This framework adds support for low-level control of the LCD
@@ -26,7 +26,7 @@ config BACKLIGHT_DEVICE
 
Quoted 11 lines

drivers/video/backlight/Kconfig config BACKLIGHT_DEVICE · line 32

Quoted 7 lines
drivers/video/backlight/Kconfig +1 -1
 config LCD_CLASS_DEVICE
         tristate "Lowlevel LCD controls"
-	depends on BACKLIGHT_LCD_SUPPORT
+	depends on BACKLIGHT_LCD_SUPPORT && FB
 	default m
 	help
 	  This framework adds support for low-level control of LCD.

Would I be correct in believing that this is a mainline fix and hence 2.6.17 material?

It's mainline fix, though I would say that it's not urgent.

Tony

-------------------------------------------------------
All the advantages of Linux Managed Hosting--Without the Cost and Risk! Fully trained technicians. The highest number of Red Hat certifications in the hosting industry. Fanatical Support. Click to learn more
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642