au1100fb: Add power management support

PATCH In review Antonino A. Daplas 2 participants 2 messages May 28, 2006 Framebuffer layer

lore

Share & tools

lore

Antonino A. Daplas

author

2006-05-28 00:43 UTC #0 lore raw

PATCH 3/5 au1100fb: Add power management support

From: Rodolfo Giometti <[email protected]>

Add power management support.

Signed-off-by Antonino Daplas <[email protected]>

---

 drivers/video/au1100fb.c |   40 ++++++++++++++++++++++++++++++++++++++--
 1 files changed, 38 insertions(+), 2 deletions(-)

drivers/video/au1100fb.c +38 -2

index f55c16a..0a800bf 100644
@@ -7,6 +7,8 @@
  *  	Karl Lessard <[email protected]>
  *  	<[email protected]>
  *
+ * PM support added by Rodolfo Giometti <[email protected]>
+ *
  * Copyright 2002 MontaVista Software
  * Author: MontaVista Software, Inc.
  *		[email protected] or [email protected]

@@ -602,17 +604,49 @@ int au1100fb_drv_remove(struct device *d
 	return 0;
 }
 
+#ifdef CONFIG_PM
+static u32 sys_clksrc;
+static struct au1100fb_regs fbregs;
+
 int au1100fb_drv_suspend(struct device *dev, pm_message_t state)
 {
-	/* TODO */
+	struct au1100fb_device *fbdev = (struct au1100fb_device*) dev_get_drvdata(dev);
+
+	if (!fbdev)
+		return 0;
+
+	/* Save the clock source state */
+	sys_clksrc = au_readl(SYS_CLKSRC);
+
+	/* Blank the LCD */
+	au1100fb_fb_blank(VESA_POWERDOWN, &fbdev->info);
+
+	/* Stop LCD clocking */
+	au_writel(sys_clksrc & ~SYS_CS_ML_MASK, SYS_CLKSRC);
+
+	memcpy(&fbregs, fbdev->regs, sizeof(struct au1100fb_regs));
+
 	return 0;
 }
 
 int au1100fb_drv_resume(struct device *dev)
 {
-	/* TODO */
+	struct au1100fb_device *fbdev = (struct au1100fb_device*) dev_get_drvdata(dev);
+
+	if (!fbdev)
+		return 0;
+
+	memcpy(fbdev->regs, &fbregs, sizeof(struct au1100fb_regs));
+
+	/* Restart LCD clocking */
+	au_writel(sys_clksrc, SYS_CLKSRC);
+
+	/* Unblank the LCD */
+	au1100fb_fb_blank(VESA_NO_BLANKING, &fbdev->info);
+
 	return 0;
 }
+#endif
 
 static struct device_driver au1100fb_driver = {
 	.name		= "au1100-lcd",

@@ -620,8 +654,10 @@ static struct device_driver au1100fb_dri
 
 	.probe		= au1100fb_drv_probe,
         .remove		= au1100fb_drv_remove,
+#ifdef CONFIG_PM
 	.suspend	= au1100fb_drv_suspend,
         .resume		= au1100fb_drv_resume,
+#endif
 };
 
 /*-------------------------------------------------------------------------*/

-------------------------------------------------------
All the advantages of Linux Managed Hosting--Without the Cost and Risk! Fully trained technicians. The highest number of Red Hat certifications in the hosting industry. Fanatical Support. Click to learn more
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642

Andrew Morton

2006-05-28 06:17 UTC #1 lore raw

drivers/video/au1100fb.c int au1100fb_drv_remove(struct device *d · line 634

Quoted 13 lines · On Sun, 28 May 2006 08:42:37 +0800 "Antonino A. Daplas" <[email protected]>…

From: Rodolfo Giometti <[email protected]>
Add power management support.
int au1100fb_drv_suspend(struct device *dev, pm_message_t state) {
drivers/video/au1100fb.c +2 -2
-	/* TODO */
+	struct au1100fb_device *fbdev = (struct au1100fb_device*) dev_get_drvdata(dev);
 
 int au1100fb_drv_resume(struct device *dev)
 {
-	/* TODO */
+	struct au1100fb_device *fbdev = (struct au1100fb_device*) dev_get_drvdata(dev);

These typecasts of void* are unneeded. They are in fact undesirable - if someone were to change the type of dev_get_drvdata() to return some non-pointer type then this code would still silently swallow it without warning us of the bug.

Plus typecasts are ugly.

This patch doesn't apply, probably due to the earlier mangled one whihc I dropped. Please redo and resend this one as well.