Skip to contentSkip to conversation

Changes to ieee80211.h for user space regulatory daemon

PATCH In review Larry Finger 2 participants 3 messages May 30, 2006 – Jun 5, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Changes to ieee80211.h for user space regulatory daemon

Attached are two small patches for include/net/ieee80211.h to prepare for later submission of code to implement a user-space daemon that supplies 802.11 regulatory information.

The first change adds a bit indicating that 802.11h rules are to be applied to a channel. As discussed earlier in this list, a single bit is unlikely to be sufficient; however, at this time I have been unable to find any regulations implementing differences between 802.11a and 802.11h other than DFS, radar detection and passive scanning. A single bit is thus sufficient to convey to the driver that these rules should be obeyed.

The second change adds comments to the freq and max_power fields of struct ieee80211_channel to indicate the units that are used.

index 293e920..6a2f60c 100644

include/net/ieee80211.h +0 -0
@@ -968,6 +968,7 @@ #define IEEE80211_52GHZ_CHANNELS (IEEE80
 
 enum {
	IEEE80211_CH_PASSIVE_ONLY = (1 << 0),
+	IEEE80211_CH_80211H_RULES = (1 << 1),
	IEEE80211_CH_B_ONLY = (1 << 2),
	IEEE80211_CH_NO_IBSS = (1 << 3),
	IEEE80211_CH_UNIFORM_SPREADING = (1 << 4),

@@ -976,10 +977,10 @@ enum {
};

struct ieee80211_channel {
- u32 freq;
+ u32 freq; /* in MHz */

	u8 channel;
	u8 flags;

- u8 max_power;
+ u8 max_power; /* in dBm */
};

struct ieee80211_geo {

#1 lore raw
Quoted 8 lines · Larry Finger

Attached are two small patches for include/net/ieee80211.h to prepare for later submission of code to implement a user-space daemon that supplies 802.11 regulatory information.

The first change adds a bit indicating that 802.11h rules are to be applied to a channel. As discussed earlier in this list, a single bit is unlikely

Review #define IEEE80211_52GHZ_CHANNELS (IEEE80 · line 974

Quoted 7 lines
(quoted diff) +1 -0
@@ -968,6 +968,7 @@ #define IEEE80211_52GHZ_CHANNELS (IEEE80
 
 enum {
 	IEEE80211_CH_PASSIVE_ONLY = (1 << 0),
+	IEEE80211_CH_80211H_RULES = (1 << 1),
 	IEEE80211_CH_B_ONLY = (1 << 2),
 	IEEE80211_CH_NO_IBSS = (1 << 3),
 	IEEE80211_CH_UNIFORM_SPREADING = (1 << 4),

Any idea why this "hole" was here to begin with? Was there something else defined as (1 << 1) previously? Is it safe to reuse this value?

John

Signature · 2 lines
John W. Linville
[email protected]
#2 lore raw
Quoted 12 lines · John W. Linville

Review #define IEEE80211_52GHZ_CHANNELS (IEEE80 · line 974

Quoted 8 lines
(quoted diff) +1 -0
@@ -968,6 +968,7 @@ #define IEEE80211_52GHZ_CHANNELS (IEEE80
 
 enum {
 	IEEE80211_CH_PASSIVE_ONLY = (1 << 0),
+	IEEE80211_CH_80211H_RULES = (1 << 1),
 	IEEE80211_CH_B_ONLY = (1 << 2),
 	IEEE80211_CH_NO_IBSS = (1 << 3),
 	IEEE80211_CH_UNIFORM_SPREADING = (1 << 4),

Any idea why this "hole" was here to begin with? Was there something else defined as (1 << 1) previously? Is it safe to reuse this value?

Quoted 1 line

John

The hole has been there as long as I have been reading the ieee80211 code. If you are not comfortable with plugging the hole, then we can use (1 << 5).

Larry