Skip to contentSkip to conversation

cpufreq-nforce2 divider

PATCH In review Sebastian Witt 2 participants 5 messages Jun 4, 2006 – Jun 6, 2006 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cpufreq-nforce2 divider

Patch against 2.6.16. Sets minimum PLL divider to 2. No negative impact when tested with two nForce2 based boards. (Updates also the (C) year)

Signed-off-by Sebastian Witt <se.witt <at> gmx net>

---

--- linux-2.6.16-gentoo-r7.orig/arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c 2006-06-04 19:32:29.000000000 +0200
+++ linux-2.6.16-gentoo-r7/arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c 2006-06-04 19:32:42.000000000 +0200 @@ -1,5 +1,5 @@
/*
- * (C) 2004 Sebastian Witt <[email protected]>
+ * (C) 2004-2006 Sebastian Witt <[email protected]>
*
* Licensed under the terms of the GNU GPL License version 2.
* Based upon reverse engineered information
@@ -90,7 +90,7 @@

        /* Try to calculate multiplier and divider up to 4 times */
        while (((mul == 0) || (div == 0)) && (tried <= 3)) {
-               for (xdiv = 1; xdiv <= 0x80; xdiv++)
+               for (xdiv = 2; xdiv <= 0x80; xdiv++)
                        for (xmul = 1; xmul <= 0xfe; xmul++)
                                if (nforce2_calc_fsb(NFORCE2_PLL(xmul, xdiv)) ==
                                    fsb + tried) {
#1 lore raw
Quoted 2 lines · Sebastian Witt

Patch against 2.6.16. Sets minimum PLL divider to 2. No negative impact when tested with two nForce2 based boards

Ok, but for the sake of the changelog, can you explain why this is a good thing ?

Dave

Signature · 1 line
http://www.codemonkey.org.uk
#2 lore raw
Quoted 4 lines · Dave Jones

Ok, but for the sake of the changelog, can you explain why this is a good thing ?

Alexander Choporov reported (06/01/06) that xdiv = 1 does not work on his Abit NF7S2. Although there shouldn't be much cases that lead to xdiv = 1.

Regards,
Sebastian

#3 lore raw
Quoted 8 lines · Sebastian Witt
Quoted 4 lines · Dave Jones

Ok, but for the sake of the changelog, can you explain why this is a good thing ?

Alexander Choporov reported (06/01/06) that xdiv = 1 does not work on his Abit NF7S2. Although there shouldn't be much cases that lead to xdiv = 1.

Ok, I've applied this by hand as your patch was badly whitespace damaged (Every tab had been converted to spaces in your diff)

Please make sure that doesn't happen for future diffs.

Thanks,

Dave

Signature · 1 line
http://www.codemonkey.org.uk
#5 lore raw

Re: REMOVE ME FROM LIST!!!

In reply to a message not in the archive
Quoted 2 lines · Pierre J Hood

I have emailed you before requesting REMOVAL from your list so I DONT RECIEVE ANY MORE EMAILS like the following FROM YOU!!!.
Please respect my wishes and remove me from your mailing list.

I've seen no such mails from you.
But at the bottom of every mail you're receiving is this footer :-

Quoted 4 lines

_______________________________________________
Cpufreq mailing list
[email protected]
http://lists.linux.org.uk/mailman/listinfo/cpufreq

From there you will be able to unsubscribe yourself, or get a reminder of your list password if you don't have it.

Dave

Signature · 1 line
http://www.codemonkey.org.uk