Skip to contentSkip to conversation

9pfs: missing result check in v9fs_vfs_readlink() and v9fs_vfs_link()

PATCH In review Florin Malita 2 participants 2 messages Jun 8, 2006 9P file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 9pfs: missing result check in v9fs_vfs_readlink() and v9fs_vfs_link()

__getname() may fail and return NULL (as pointed out by Coverity 437 & 1220).

---

 fs/9p/vfs_inode.c |    6 ++++++
 1 file changed, 6 insertions(+)
fs/9p/vfs_inode.c +6 -0
index 2cb87ba..8e60dc7 100644
@@ -1054,6 +1054,9 @@ static int v9fs_vfs_readlink(struct dent
 	int ret;
 	char *link = __getname();
 
+	if (unlikely(!link))
+		return -ENOMEM;
+
 	if (buflen > PATH_MAX)
 		buflen = PATH_MAX;
 
@@ -1227,6 +1230,9 @@ v9fs_vfs_link(struct dentry *old_dentry,
 	}
 
 	name = __getname();
+	if (unlikely(!name))
+		return -ENOMEM;
+
 	sprintf(name, "%d\n", oldfid->fid);
 	retval = v9fs_vfs_mkspecial(dir, dentry, V9FS_DMLINK, name);
 	__putname(name);