Skip to contentSkip to conversation

Add KERN constants to arch/i386/kernel/cpu/rise.c

PATCH In review Matthew Martin 3 participants 3 messages Jun 11, 2006 – Jun 12, 2006 Kernel janitors

lore
Share & tools
lore

Matthew Martin

author
#0 lore raw

PATCH 1/1 Add KERN constants to arch/i386/kernel/cpu/rise.c

Hello,
This adds KERN constants to arch/i386/kernel/cpu/rise.c

Signed-off-by Matthew Martin <[email protected]>

---

arch/i386/kernel/cpu/rise.c +2 -2
@@ -7,9 +7,9 @@
 
 static void __init init_rise(struct cpuinfo_x86 *c)
 {
-	printk("CPU: Rise iDragon");
+	printk(KERN_INFO "CPU: Rise iDragon");
 	if (c->x86_model > 2)
-		printk(" II");
+		printk(KERN_INFO " II");
 	printk("\n");
 
 	/* Unhide possibly hidden capability flags

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw
Quoted 10 lines · Matthew Martin

Hello,
This adds KERN constants to arch/i386/kernel/cpu/rise.c

Signed-off-by Matthew Martin <[email protected]>

---

arch/i386/kernel/cpu/rise.c line 13

Quoted 9 lines
arch/i386/kernel/cpu/rise.c +2 -2
@@ -7,9 +7,9 @@
 
 static void __init init_rise(struct cpuinfo_x86 *c)
 {
-	printk("CPU: Rise iDragon");
+	printk(KERN_INFO "CPU: Rise iDragon");
 	if (c->x86_model > 2)
-		printk(" II");
+		printk(KERN_INFO " II");
 	printk("\n");

Note that there's no \n on the first printk. This means that adding teh KERN_INFO to the second printk is incorrect, as it'll result in output like..

CPU: Rise iDragon<6> II

Dave

Signature · 5 lines
http://www.codemonkey.org.uk
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors
#2 lore raw
In reply to Matthew Martin
Quoted 24 lines · On Sun, 11 Jun 2006 19:30:34 -0400 Dave Jones wrote:
Quoted 10 lines · Matthew Martin

Hello,
This adds KERN constants to arch/i386/kernel/cpu/rise.c

Signed-off-by Matthew Martin <[email protected]>

---

arch/i386/kernel/cpu/rise.c line 13

Quoted 9 lines
arch/i386/kernel/cpu/rise.c +2 -2
@@ -7,9 +7,9 @@
 
 static void __init init_rise(struct cpuinfo_x86 *c)
 {
-	printk("CPU: Rise iDragon");
+	printk(KERN_INFO "CPU: Rise iDragon");
 	if (c->x86_model > 2)
-		printk(" II");
+		printk(KERN_INFO " II");
 	printk("\n");

Note that there's no \n on the first printk. This means that adding teh KERN_INFO to the second printk is incorrect, as it'll result in output like..

Quoted 1 line

CPU: Rise iDragon<6> II

which is why the KJ TODO says:

- printk() calls should include appropriate KERN_* constant (of course only at beginning of lines).

---
~Randy
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors