Skip to contentSkip to conversation

tmpfs: add export_operations to allow export via NFS

PATCH In review Gilad Ben-Yossef 2 participants 2 messages Jun 22, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tmpfs: add export_operations to allow export via NFS

From: Atal Shargorodsky <[email protected]>

This patch adds export_operations callbacks to tmpfs to allow exporting tmpfs mounts via knfsd.

---

Caveats
~~~~~~~

Due to the lack of backing device, the use of the 'fsid' export option is required for this to work.

The question of whether two different mounts of tmpfs exported at the same path are considered exports of the same volume (e.g.: export /tmp, reboot, export /tmp again) has been left to the user: if you think they are different, assign a different 'fsid', if you think they are not, re-use the same 'fsid'.

Support for exporting a tmpfs volume with a large numbers of files will require switching to a more scalable way to traverse the inode list then the current linked list.

Tested on i386 and PowerPC, uniproccesors only.

Thank you goes to Muli Ben-Yehuda for his help in proof reading the original patch.

mm/shmem.c renamed from mm/shmem.c.orig +93 -0
@@ -74,6 +74,84 @@
 /* Pretend that each entry is of this size in directory's i_size */
 #define BOGO_DIRENT_SIZE 20
 
+#define TMPFS_EXPORT_MAGIC 102
+#define TMPFS_ROOT_INO 1
+static unsigned long shmem_export_ino_seq; /* not atomic_t because of using
+						lock anyway */
+static spinlock_t shmem_export_spin_lock;  /* because the need to update ino
+						and generation as atomic operation */
+static __u32 shmem_export_curr_generation; /* remember current generation */
+
+struct dentry * shmem_export_get_parent(struct dentry *child)
+{
+/* We don't want this function to succeed. because it's only
+called in situations that should not be handled by tmpfs.
+Reboot , just like umount/mount, creates NEW filesystem, so
+previously holded filehandlers are irrelevant */
+	return ERR_PTR(-ESTALE);
+}
+
+struct dentry * shmem_export_get_dentry(struct super_block *sb, void *fh)
+{
+	struct inode * inode = NULL;
+	struct inode * found_inode = NULL;
+	struct dentry * result;
+	unsigned long ino  = * (unsigned long *) fh;
+	__u32 generation  = * (__u32 *) (fh + sizeof(ino));
+	spin_lock(&inode_lock);	
+	list_for_each_entry(inode, &sb->s_inodes, i_sb_list) {
+		if ((inode->i_ino == ino) &&
+			(inode->i_generation == generation)){
+			found_inode = inode;
+			break;
+		}
+	}
+  spin_unlock(&inode_lock);
+	if (!found_inode)
+		return ERR_PTR(-ESTALE);
+	result = d_find_alias(inode);
+	if (result == NULL)
+		return ERR_PTR(-ESTALE);
+	result->d_op = sb->s_root->d_op;
+	return result;
+}
+
+int shmem_export_encode_fh(struct dentry * dentry, __u32 *fh,int *lenp,
+			int connectable)
+{
+	struct inode *inode = dentry->d_inode;
+	char * raw = (char *)fh;
+	int room = sizeof (inode->i_ino) + sizeof (inode->i_generation);
+	if (*lenp < room + 1)
+		return 255; /* no room */
+	* (unsigned long *)(raw)=inode->i_ino;
+	* (__u32 *)(raw + sizeof(inode->i_ino)) =
+		inode->i_generation;
+	raw[room] = TMPFS_EXPORT_MAGIC;
+	*lenp=room+1;
+	return *lenp;
+}
+
+struct dentry *shmem_export_decode_fh(struct super_block *sb,
+			__u32 *data, int len, int fhtype,
+			int (*acceptable)(void *context, struct dentry * de),
+			void *context)
+{
+	char * raw = (char *)data;
+	int room = sizeof (unsigned long) + sizeof (__u32);
+	if (len < room+1 || raw[room] != TMPFS_EXPORT_MAGIC)
+		return ERR_PTR(-ESTALE);
+	return sb->s_export_op->find_exported_dentry(sb,data,NULL,
+		acceptable,context);
+}
+
+static struct export_operations shmem_export_ops = {
+	.get_parent = shmem_export_get_parent,
+	.get_dentry = shmem_export_get_dentry,
+	.encode_fh = shmem_export_encode_fh,
+	.decode_fh = shmem_export_decode_fh,
+};
+
 /* Flag allocation requirements to shmem_getpage and shmem_swp_alloc */
 enum sgp_type {
 	SGP_QUICK,	/* don't try more than file page cache lookup */
@@ -1357,6 +1435,14 @@ shmem_get_inode(struct super_block *sb,
 
 	inode = new_inode(sb);
 	if (inode) {
+		spin_lock(&shmem_export_spin_lock);
+		inode->i_ino = ++shmem_export_ino_seq;
+		if (!inode->i_ino){
+			inode->i_ino = TMPFS_ROOT_INO + 1;
+			shmem_export_curr_generation++;
+		}
+		inode->i_generation = shmem_export_curr_generation;
+		spin_unlock(&shmem_export_spin_lock);
 		inode->i_mode = mode;
 		inode->i_uid = current->fsuid;
 		inode->i_gid = current->fsgid;
@@ -2103,6 +2189,7 @@ static int shmem_fill_super(struct super
 	sb->s_blocksize_bits = PAGE_CACHE_SHIFT;
 	sb->s_magic = TMPFS_MAGIC;
 	sb->s_op = &shmem_ops;
+	sb->s_export_op = &shmem_export_ops;
 	sb->s_time_gran = 1;
 
 	inode = shmem_get_inode(sb, S_IFDIR | mode, 0);
@@ -2110,6 +2197,11 @@ static int shmem_fill_super(struct super
 		goto failed;
 	inode->i_uid = uid;
 	inode->i_gid = gid;
+	spin_lock(&shmem_export_spin_lock);
+	shmem_export_ino_seq = TMPFS_ROOT_INO;
+	inode->i_ino = TMPFS_ROOT_INO;
+	inode->i_generation = ++shmem_export_curr_generation;
+	spin_unlock(&shmem_export_spin_lock);
 	root = d_alloc_root(inode);
 	if (!root)
 		goto failed_iput;
@@ -2251,6 +2343,7 @@ static int __init init_tmpfs(void)
 {
 	int error;
 
+	spin_lock_init(&shmem_export_spin_lock);
 	error = init_inodecache();
 	if (error)
 		goto out3;
Signature · 7 lines
Gilad Ben-Yossef <[email protected]>
Codefidence. A name you can trust(tm)
Web: http://codefidence.com  | SIP: [email protected]
IL: +972.3.7515563 ext. 201  | Fax:            +972.3.7515503
US: +1.212.2026643 ext. 201  | Cel:           +972.52.8260388

	The journey of a thousand miles begins with a single "oy."
#1 lore raw

Hi Gilad,

A few more stylistic comments:

mm/shmem.c line 80

Quoted 10 lines · Gilad Ben-Yossef
mm/shmem.c renamed from mm/shmem.c.orig +4 -0
@@ -74,6 +74,84 @@
 /* Pretend that each entry is of this size in directory's i_size */
 #define BOGO_DIRENT_SIZE 20
 
+#define TMPFS_EXPORT_MAGIC 102
+#define TMPFS_ROOT_INO 1
+static unsigned long shmem_export_ino_seq; /* not atomic_t because of using
+						lock anyway */

These comments should probably be moved before the declaration.

Quoted 4 lines
mm/shmem.c renamed from mm/shmem.c.orig +1 -0
+static spinlock_t shmem_export_spin_lock;  /* because the need to update 

ino

mm/shmem.c renamed from mm/shmem.c.orig +1 -0
+						and generation as atomic 

operation */

Same thing wrt comment. Also this should probably be DEFINE_SPINLOCK.

Quoted 2 lines

+static __u32 shmem_export_curr_generation; /* remember current generation */

Same thing wrt comment.

mm/shmem.c line 90

Quoted 7 lines
mm/shmem.c renamed from mm/shmem.c.orig +7 -0
+
+struct dentry * shmem_export_get_parent(struct dentry *child)
+{
+/* We don't want this function to succeed. because it's only
+called in situations that should not be handled by tmpfs.
+Reboot , just like umount/mount, creates NEW filesystem, so
+previously holded filehandlers are irrelevant */

Please use the
/*
* foo
*/

style for multi-line comments.

Quoted 9 lines
mm/shmem.c renamed from mm/shmem.c.orig +9 -0
+	return ERR_PTR(-ESTALE);
+}
+
+struct dentry * shmem_export_get_dentry(struct super_block *sb, void *fh)
+{
+	struct inode * inode = NULL;
+	struct inode * found_inode = NULL;
+	struct dentry * result;
+	unsigned long ino  = * (unsigned long *) fh;

mm/shmem.c line 109

Quoted 10 lines
mm/shmem.c renamed from mm/shmem.c.orig +10 -0
+	__u32 generation  = * (__u32 *) (fh + sizeof(ino));
+	spin_lock(&inode_lock);	
+	list_for_each_entry(inode, &sb->s_inodes, i_sb_list) {
+		if ((inode->i_ino == ino) &&
+			(inode->i_generation == generation)){
+			found_inode = inode;
+			break;
+		}
+	}
+  spin_unlock(&inode_lock);

There's something wrong with the indentation here.

Quoted 10 lines
mm/shmem.c renamed from mm/shmem.c.orig +10 -0
+	if (!found_inode)
+		return ERR_PTR(-ESTALE);
+	result = d_find_alias(inode);
+	if (result == NULL)
+		return ERR_PTR(-ESTALE);
+	result->d_op = sb->s_root->d_op;
+	return result;
+}
+
+int shmem_export_encode_fh(struct dentry * dentry, __u32 *fh,int *lenp,

mm/shmem.c line 129

Quoted 10 lines
mm/shmem.c renamed from mm/shmem.c.orig +10 -0
+			int connectable)
+{
+	struct inode *inode = dentry->d_inode;
+	char * raw = (char *)fh;
+	int room = sizeof (inode->i_ino) + sizeof (inode->i_generation);
+	if (*lenp < room + 1)
+		return 255; /* no room */
+	* (unsigned long *)(raw)=inode->i_ino;
+	* (__u32 *)(raw + sizeof(inode->i_ino)) =
+		inode->i_generation;

This can be on the same line.

mm/shmem.c line 131

Quoted 2 lines
mm/shmem.c renamed from mm/shmem.c.orig +2 -0
+	raw[room] = TMPFS_EXPORT_MAGIC;
+	*lenp=room+1;

space before and after ' = '.

Quoted 27 lines
mm/shmem.c renamed from mm/shmem.c.orig +23 -0
+	return *lenp;
+}
+
+struct dentry *shmem_export_decode_fh(struct super_block *sb,
+			__u32 *data, int len, int fhtype,
+			int (*acceptable)(void *context, struct dentry * de),
+			void *context)
+{
+	char * raw = (char *)data;
+	int room = sizeof (unsigned long) + sizeof (__u32);
+	if (len < room+1 || raw[room] != TMPFS_EXPORT_MAGIC)
+		return ERR_PTR(-ESTALE);
+	return sb->s_export_op->find_exported_dentry(sb,data,NULL,
+		acceptable,context);
+}
+
+static struct export_operations shmem_export_ops = {
+	.get_parent = shmem_export_get_parent,
+	.get_dentry = shmem_export_get_dentry,
+	.encode_fh = shmem_export_encode_fh,
+	.decode_fh = shmem_export_decode_fh,
+};
+
 /* Flag allocation requirements to shmem_getpage and shmem_swp_alloc */
 enum sgp_type {
 	SGP_QUICK,	/* don't try more than file page cache lookup */

mm/shmem.c shmem_get_inode(struct super_block *sb, · line 1440

Quoted 6 lines
mm/shmem.c renamed from mm/shmem.c.orig +3 -0
@@ -1357,6 +1435,14 @@ shmem_get_inode(struct super_block *sb,
 
 	inode = new_inode(sb);
 	if (inode) {
+		spin_lock(&shmem_export_spin_lock);
+		inode->i_ino = ++shmem_export_ino_seq;
+		if (!inode->i_ino){

space before {

Quoted 29 lines
mm/shmem.c renamed from mm/shmem.c.orig +11 -0
+			inode->i_ino = TMPFS_ROOT_INO + 1;
+			shmem_export_curr_generation++;
+		}
+		inode->i_generation = shmem_export_curr_generation;
+		spin_unlock(&shmem_export_spin_lock);
 		inode->i_mode = mode;
 		inode->i_uid = current->fsuid;
 		inode->i_gid = current->fsgid;
@@ -2103,6 +2189,7 @@ static int shmem_fill_super(struct super
 	sb->s_blocksize_bits = PAGE_CACHE_SHIFT;
 	sb->s_magic = TMPFS_MAGIC;
 	sb->s_op = &shmem_ops;
+	sb->s_export_op = &shmem_export_ops;
 	sb->s_time_gran = 1;
 
 	inode = shmem_get_inode(sb, S_IFDIR | mode, 0);
@@ -2110,6 +2197,11 @@ static int shmem_fill_super(struct super
 		goto failed;
 	inode->i_uid = uid;
 	inode->i_gid = gid;
+	spin_lock(&shmem_export_spin_lock);
+	shmem_export_ino_seq = TMPFS_ROOT_INO;
+	inode->i_ino = TMPFS_ROOT_INO;
+	inode->i_generation = ++shmem_export_curr_generation;
+	spin_unlock(&shmem_export_spin_lock);
 	root = d_alloc_root(inode);
 	if (!root)
 		goto failed_iput;

mm/shmem.c static int __init init_tmpfs(void) · line 2346

Quoted 4 lines
mm/shmem.c renamed from mm/shmem.c.orig +1 -0
@@ -2251,6 +2343,7 @@ static int __init init_tmpfs(void)
 {
 	int error;
 
+	spin_lock_init(&shmem_export_spin_lock);

You can get rid of this if you use DEFINE_SPINLOCK.

Cheers,
Muli